Unable to `zap` non-`.class` files about jarjar-abrams HOT 5 CLOSED

I was thinking of removing this constraint to zap, but wanted to see if there were any objections before going too far down that path.

I kind of like the idea of removing the *.class only constraint rather than adding a new vocabulary that we now need to remember to support. @johnynek wdyt?

from jarjar-abrams.

I agree that reusing zap is ideal and removing non-class files from a jar is a real use case.

from jarjar-abrams.

I initially played around with updating zap to allow for other files, but realized that the way that it handled the pattern implicitly assumes that it's going to be operating on Java packages (eg: org.apache.kafka.**) instead of file paths (eg: org/apache/kafka/**/*.proto). That's when I took the route in #49 to separate out then handling of zaping Java packages versus zaping general file paths within the input jarfile.

from jarjar-abrams.

👋 Hi Eugene, Oscar.

Thanks Adam for your PR. I've prepared PR #53 that generalizes zap.

Since rule does match resources (based only on their path, not their filename) changing zap to mirror this behavior seems appropriate.

from jarjar-abrams.

Thanks for the contribution @patrick-premont! #53 is merged.

from jarjar-abrams.