Comments (5)
I was thinking of removing this constraint to
zap
, but wanted to see if there were any objections before going too far down that path.
I kind of like the idea of removing the *.class
only constraint rather than adding a new vocabulary that we now need to remember to support. @johnynek wdyt?
from jarjar-abrams.
I agree that reusing zap is ideal and removing non-class files from a jar is a real use case.
from jarjar-abrams.
I initially played around with updating zap
to allow for other files, but realized that the way that it handled the pattern
implicitly assumes that it's going to be operating on Java packages (eg: org.apache.kafka.**
) instead of file paths (eg: org/apache/kafka/**/*.proto
). That's when I took the route in #49 to separate out then handling of zap
ing Java packages versus zap
ing general file paths within the input jarfile.
from jarjar-abrams.
👋 Hi Eugene, Oscar.
Thanks Adam for your PR. I've prepared PR #53 that generalizes zap
.
Since rule
does match resources (based only on their path, not their filename) changing zap
to mirror this behavior seems appropriate.
from jarjar-abrams.
Thanks for the contribution @patrick-premont! #53 is merged.
from jarjar-abrams.
Related Issues (20)
- Support for multiple libraries for the jarjarLibraryDependency setting? HOT 3
- Vendor pantsbuild/jarjar sources, and bump its asm dependency HOT 1
- ShadeRules.keep is broken HOT 2
- Make a patch release HOT 2
- sbt-assembly v1.2.0: Facing java.lang.ArrayIndexOutOfBoundsException: Index 65536 out of bounds for length 132 HOT 1
- Error when shading package but not subpackage
- Cannot shade traits containg fields
- Release 1.8.2 HOT 1
- Run CLI on Shapeless HOT 4
- asm: java.lang.ArrayIndexOutOfBoundsException: Index 65536 out of bounds for length _
- `com.eed3si9n.jarjar.JarJarTask` is missing in jarjar 1.13.1 HOT 1
- Jarjar mangles classes even when no meaningful transformation applied HOT 2
- Empty "directories" remain in output jar after using `zap`
- Kotlin Metadata is not relocated
- Keep rule does not keep dependencies
- Document `Shader.bytecodeShader` API change in version `1.10.0` HOT 2
- Way to 'zap' files at the root?
- sbt build warnings HOT 1
- Feature Request - Retain comments/licenses in merged service provider files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jarjar-abrams.