Git Product home page Git Product logo

Comments (6)

ckru-kiel avatar ckru-kiel commented on July 26, 2024

the field "Date" is missing
Start --> TimeStart
Finish --> TimeEnd
Currently Start and finish are datetimes so technically one session could last through a day change. For hypothetical events like a weeekend seminar or a special event overnight session like night of the profs or whatever.

from eduhub.

ckru-kiel avatar ckru-kiel commented on July 26, 2024

Join Table für "Address" (not Location)
but an address table doesnt exist. what should it look like and how is it related to location?

from eduhub.

steffen74 avatar steffen74 commented on July 26, 2024

the field "Date" is missing
Start --> TimeStart
Finish --> TimeEnd
Currently Start and finish are datetimes so technically one session could last through a day change. For hypothetical events like a weeekend seminar or a special event overnight session like night of the profs or whatever.

You are right it should rather be re-named to startDateTime and endDatetime.

from eduhub.

steffen74 avatar steffen74 commented on July 26, 2024

Join Table für "Address" (not Location)
but an address table doesnt exist. what should it look like and how is it related to location?

@ckru-cbb The former table location should be renamed to the table address. (I just noticed, there is a typo in the field Longitude.)
Also, the new table location can simply be an ENUM.
There is no technical relationship between the tables location and address.

from eduhub.

fschindler avatar fschindler commented on July 26, 2024

I've just finished my review on #75 and merged it.

@steffen74 @ckru-cbb should we close this issue?

from eduhub.

steffen74 avatar steffen74 commented on July 26, 2024

I've just finished my review on #75 and merged it.

@steffen74 @ckru-cbb should we close this issue?

Sounds good!

from eduhub.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.