View diff images in image viewer about git-image-diff HOT 2 OPEN

Nice. I didn't know about GIT_DIFF_PATH_COUNTER or GIT_DIFF_PATH_TOTAL. Try to make it cross-platform by not depending on platform-specific software.

I would probably prefer to just look through the generated image files manually, i.e. have it just open the folder in the GUI or so. On OS X you can do open path/to/dir/, not sure what all the different linuxes use. But if you're going to make /tmp configurable, maybe what happens can be configurable too. Although I tend to prefer convention over configuration when possible.

from git-image-diff.

After some experimentation I realize that GIT_DIFF_PATH_COUNTER and GIT_DIFF_PATH_TOTAL refer to the total number of files which would make it useless in this case for finding when all images have been generated.

There is no way to not make this platform dependent, or rather need a configuration for what viewer should be used. open renders an error when used on a folder in xubuntu so that's just as bad as relying on ristretto. "...open the folder with a configured image viewer...". I'm not aware of any general convention for opening a folder containing images.

from git-image-diff.