Import recipes via BeerXML about brewshopapp HOT 14 CLOSED

I have a working Java Implementation for BeerXML, I can port it over.

from brewshopapp.

Hey, that would be cool. Your sax parser should drop right in. In fact, your whole StrangeBrew application looks pretty well evolved. I feel like I'm staring into the future... :)

from brewshopapp.

Pull request for the Import: #20

I'll be working on Export today

from brewshopapp.

I'm trying to open a BeerXML file but it won't let me open a file either locally or on Google Drive. They're always greyed out. What am I doing wrong?

from brewshopapp.

It may not be a valid BeerXML. Do you have the file itself?

from brewshopapp.

Here's the file I'm trying to open

https://20d9624d8d07ea39df88bc9bdc75d1bdfd27ec65.googledrive.com/host/0B2h6PT8E-KfoNUgwekkwSkI3X1k/3-floyds-zombie-dust-clone.xml

I can browse to it but I just can't click it.

from brewshopapp.

Where abouts are you storing the file? I can open it in the emulator, but I found a couple of exceptions which I've made a pull request for.

from brewshopapp.

I'm trying to open it from my 'Public' folder on Google Drive. I also tried downloading it and opening it from the local filesystem. All the files just look disabled. I'll try it on the emulator later.

from brewshopapp.

OK, it's a bug in the default file intent handler on Android devices, the Emulator doesn't show the same behaviour. I've pushed a new pull request to address it and to show a dialog indicating how many recipes were opened.

from brewshopapp.

The 'open recipe' feature is looking really good. I just have a few nit-picky requests then I'd like to ahead and publish this feature.

1. Instead of a dialog asking for 'New' or 'Open' can you have the '+' icon create a new recipe by default and add a separate action bar overflow option (the three vertical dot menu thingy) for "Open recipe file..." or "Open BeerXML file..."? I think users will create new recipes more often and I'd like to retain the one-click action.
2. Have a modal "Opening Recipe File..." dialog show while opening a recipe. It takes a few seconds on my phone to open the Zombie Dust recipe and it just looks like nothing's happening.
3. Change the "Opened 1 Recipe" dialog to a Toast with Toast.SHORT duration. Also, can you use 'Opened recipe' (singular) or 'Opened X recipes' if multiple are loaded?
4. When I open the Zombie Dust recipe the style shows "American IPA" until I try editing recipe information. The style selection defaults to "California Common" instead of "American IPA". Can you find out what's going on there?

On a side note I don't know what to do if we don't have a matching style. We don't currently support custom style names. Maybe we need to add that in the future.

Cheers! -E

from brewshopapp.

Closing this enhancement after integrating the latest PR in commit f207152

from brewshopapp.

I'm trying to write up some tests for this. But I'm unsure how to load the JSON data from the test suite. Any ideas?

from brewshopapp.

Here's a stackoverflow thread on accessing resources in apps under test. I haven't tried it but it sounds like it works.

http://stackoverflow.com/questions/3901342/android-accessing-test-application-assets

Once you get access you can use the Gson library to deserialize it into storage objects like we do in the app.

from brewshopapp.

Thanks, new Pull request based on the added tests. Should fix most of the issues. I'll look into the Google Drive uploads after this.

from brewshopapp.