code-review: jsPDF.text(...), is the parameter out of order? about jspdf-invoice-template HOT 8 CLOSED

Thanks @edisonneza

Progressively journalled notes as I went through 😅

Still uncertain which parts of jsPDF are documented as feature vs bug 🐛 itself :P - will see whether we get further (official) responses from their issue tracker - otherwise some of my drop-in types may have to do in the short—to medium—term.

I added a comment to a font metrics issue to start (will find and reference back) with a sample of expected input/output interface shape)

Working things through - I will hopefully be able to incrementally separate it in a maintainable fashion to PR back

May be a while :S

from jspdf-invoice-template.

😯😳 lots of topics in a single issue haha. I will try to seprate them, or if you can it would be the best to create a PR if you're gonna do any fix or features. Tomorrow I will work on the fix of the other issue and publish the package. Thanks for the contribution!!

from jspdf-invoice-template.

Bouncing around ideas / discussion 🙌

from jspdf-invoice-template.

Also I think the text alignment property may not be working due to this similar issue

and, on delving in, it looks like the text() function expects the align property within a settings object rather than as a direct string

  export interface TextOptionsLight {
    align?: "left" | "center" | "right" | "justify";

from jspdf-invoice-template.

This usage is different to the other times the function is used in the file

https://github.com/edisonneza/jspdf-invoice-template/blob/main/src/index.js#L477

        /* no compile-time warning */
        doc.text(
          param.pageLabel + " " + i + " / " + doc.getNumberOfPages(),
          docWidth - 20,
          doc.internal.pageSize.height - 6
        );

also noting a non-bug (for this repo) as I was wondering why doc.getPageWidth() raised errors on transpile

  var getPageWidth = (API.getPageWidth = function(pageNumber) {
    pageNumber = pageNumber || currentPage;
    return (
      (pagesContext[pageNumber].mediaBox.topRightX -
        pagesContext[pageNumber].mediaBox.bottomLeftX) /
      scaleFactor
    );
  });

• this is actually a jsPDF bug where it is missing type declarations for some parts and not others.

A common issue in many longstanding js dependencies

from jspdf-invoice-template.

js vs the documented index.d.ts discrepancies get tedious to review as the footer did appear to be centered at the bottom

however,
the types expected a settings object instead of the string "center"

                doc.text(
                    param.footer.text,
                    docWidth / 2,
                    docHeight - 10,
                    "center"
                );

from jspdf-invoice-template.

^ Wondering if right alignment is present for decimal currency fields as part of the table

from jspdf-invoice-template.

Added in my TODO list. Reopen it if anything else.

from jspdf-invoice-template.