Comments (4)
Oh no, thanks for reporting @nicolemarsaglia!
Earlier this year, we transitioned the old data structure layout of AMReX in WarpX from a mix of AoS + SoA to be purely SoA now. I am pretty sure that must have broken it.
Here are the PRs:
Do those look correct to you?
I noticed at the time that CI was missing for Ascent in AMReX and maybe a bug slipped through...
from warpx.
Do you think the specific line that fails on
n_coords["values/x"].set_external(const_cast<ParticleReal*>(&soa.GetRealData(0)[0]),
num_particles);
needs a guard for zero particles on an MPI rank? That can definitely happen and accessing [0]
in that case would be a memory violation...
from warpx.
I think there is another issue there further down the code:
https://github.com/AMReX-Codes/amrex/blob/c09da9977004a32ab4f209fba6114c7889a0a5bd/Src/Extern/Conduit/AMReX_Conduit_Blueprint_ParticlesI.H#L185-L196
We now have a 64bit cpuid
attribute to uniquely identify particles. In the linked code, it uses an intermediate version where we split both into 32bit numbers, which was not final. Sorry this slipped through. Do you or @cyrush know how to update this for Conduit?
You need to use soa.GetIdCPUData()
for this branch instead of the current logic - and again, there can be zero particles on an MPI rank.
from warpx.
Fixed via AMReX-Codes/amrex#4065.
This will come in after the WarpX 24.08 release (which depends on AMReX 24.08, which is already tagged), via the next weekly AMReX update.
from warpx.
Related Issues (20)
- PICMI documentation is gone HOT 4
- Issue with Limiting External Electric Field to Specific Boundary in 3D Simulation HOT 9
- Clean code: remove `tmp_particle_data`
- Bug: Invalid memory access occurred during AMReX::GpuDevice::streamSynchronize HOT 10
- Convergence behavior of electrostatic solver changes whether embedded boundary support is on or off HOT 2
- Cannot get FFT method to work for electrostatic solver HOT 5
- NumPy 2.0 Compatibility HOT 5
- Runtime error with Laser Ion acceleration test run HOT 9
- Clean code: avoid duplication in Source/Parallelization/WarpXComm.cpp
- How to utilize WarpX to investigate the evolution of relativistic electron beams in vacuum HOT 2
- Laser injected at an angle having non-physical effects HOT 2
- WarpX SENSEI in-situ with VisIt got segmentation fault HOT 1
- CFL limitation for electrostatic simulations HOT 5
- Minimum pb alpha particle energy lower than expected
- Particle injector and scaling for astrophysical plasma setup HOT 2
- An initial attempt to run WarpX at Los Alamos
- Installation on lxplus fails
- Laser focal position using PICMI inputs
- Too much memory required for checking domain with moving window
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from warpx.