Uncompleted transaction Future after close connection about vertx-sql-client HOT 4 CLOSED

I can see that too, can you elaborate how the control flow changes by setting the status to closed when the channel inactive is set first @kkoderok ?

from vertx-sql-client.

As I can see, when a connection is closed, the method PgCodec#fail completes query execution future with exception, by calling ctx.fireChannelRead(failure). This result leads to rollback of current transaction in the withTransaction method. The PgSocketConnection has no disconnection status, so it sends rollback command. In this case we add ClosePortalCommandCodec in the deque (PgCodec.inflight), but current iterator doesn't notice this command.
If we change call order, rollback request will be immediately failed with exception by PgSocketConnection.

from vertx-sql-client.

thanks , I missed the rollback

from vertx-sql-client.

thanks for the reproducer and analysis, the codec classes should actually record the failure and fail new command registered against the codec, so in response of the failure, the rollback command will be fail immediately by the codec. Your suggestion was also correct, but relying on the timing instead on the failed state that should be recorded to prevent execution of the pipeline for new commands.

from vertx-sql-client.