Git Product home page Git Product logo

Comments (2)

adamfarley avatar adamfarley commented on May 23, 2024

This seems a fairly straightforward change. However this website states that OpenJDK 9 on HotSpot supports SLES 11.

https://wiki.openjdk.java.net/display/Build/Supported+Build+Platforms

If this is also the case for OpenJDK on OpenJ9, then we may have to specify the command location explicitly, as the sles 11 machine I checked (jsvt004g.hursley.ibm.com) says: "update-alternatives: command not found". Some websites online say others have this problem also, so this may not be a simple setup bug.

For reference, update-alternative is found in /usr/sbin/update-alternatives

So the docker files with bits that look like this:

# Create links for c++,g++,cc,gcc
RUN ln -s g++ /usr/bin/c++
&& ln -s g++-4.8 /usr/bin/g++
&& ln -s gcc /usr/bin/cc
&& ln -s gcc-4.8 /usr/bin/gcc

Would probably end up looking something like this:

# Create links for c++,g++,cc,gcc
RUN /usr/sbin/update-alternatives --install /usr/bin/g++ g++ /usr/bin/c++
RUN /usr/sbin/update-alternatives --install /usr/bin/g++-4.8 g++-4.8 /usr/bin/g++
RUN /usr/sbin/update-alternatives --install /usr/bin/gcc gcc /usr/bin/cc
RUN /usr/sbin/update-alternatives --install /usr/bin/gcc-4.8 gcc-4.8 /usr/bin/gcc

And here's a list of the docker files that could likely use this change:

https://github.com/eclipse/openj9/blob/master/buildenv/docker/jdk9/x86_64/ubuntu16/Dockerfile
https://github.com/eclipse/openj9/blob/master/buildenv/docker/jdk9/ppc64le/ubuntu16/Dockerfile
https://github.com/eclipse/openj9/blob/master/buildenv/docker/jdk9/s390x/ubuntu16/Dockerfile
https://github.com/eclipse/openj9/blob/master/buildenv/docker/test/Dockerfile

Note: The test Dockerfile had a -f in the ln, and I'm not seeing a "force" option for update-alternatives, so perhaps a quiet rm?

Does that sound right?

from openj9.

mgaudet avatar mgaudet commented on May 23, 2024

If I recall correctly, update-alternatives only exists on Debian derived linux distributions, of which Ubuntu is one, but SLES is not -- so a SLES docker container will need a different choice.

Everything else looks about right to me based on inspection.

I am currently 😷, and so I am slower than usual. Take what I say with a grain of salt

from openj9.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.