Git Product home page Git Product logo

Comments (6)

pshipton avatar pshipton commented on June 9, 2024

@keithc-ca any ideas?

from openj9.

keithc-ca avatar keithc-ca commented on June 9, 2024

I've seen this myself and wasn't quite sure why it didn't happen in jenkins builds. I narrowed it down to management of dependencies for .nasm files. I'm updating my cmake version, perhaps it's fixed already.

from openj9.

pshipton avatar pshipton commented on June 9, 2024

Related to https://github.ibm.com/runtimes/infrastructure/issues/8822

from openj9.

keithc-ca avatar keithc-ca commented on June 9, 2024

cmake version 3.28.3 didn't fare any better.

from openj9.

AswathySK avatar AswathySK commented on June 9, 2024

@keithc-ca ,
cmake version in most of our build machines are 3.14.5. And personally when I encountered this error last time rolling down cmake to 3.20.1 did the trick.

What do you think is different in higher cmake versions that might be causing this issue?

from openj9.

keithc-ca avatar keithc-ca commented on June 9, 2024

Older versions of cmake don't automatically track dependencies for .nasm files. It seems the new tracking doesn't play nicely with our use of fixpath.sh.

For example, consider AMD64CompressString.nasm; nasm creates a .d file which says:

runtime/compiler/CMakeFiles/j9jit.dir/x/amd64/runtime/AMD64CompressString.nasm.obj : \
  c:\space\jdk21\openj9\runtime\compiler\x\amd64\runtime\AMD64CompressString.nasm \
  c:\space\jdk21\build\normal\vm\runtime\oti\jilconsts.inc \
  c:\space\jdk21\openj9\runtime\compiler\x\amd64\runtime\AMD64CompressString.inc

Then cmake translates this the following rule in runtime/compiler/CMakeFiles/j9jit.dir/compiler_depend.make:

runtime/compiler/CMakeFiles/j9jit.dir/x/amd64/runtime/AMD64CompressString.nasm.obj: /cygdrive/c/space/jdk21/openj9/runtime/compiler/x/amd64/runtime/AMD64CompressString.nasm \
  runtime/compiler/c:/space/jdk21/build/normal/vm/runtime/oti/jilconsts.inc \
  runtime/compiler/c:/space/jdk21/openj9/runtime/compiler/x/amd64/runtime/AMD64CompressString.inc \
  runtime/compiler/c:/space/jdk21/openj9/runtime/compiler/x/amd64/runtime/AMD64CompressString.nasm

It seems that cmake's preference for using relative paths doesn't work so well.

My plan is to just disable automatic dependency management for .nasm files on Windows.

from openj9.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.