Unhandled null in getWorkDoneProgress() breaks Vim usage about eclipse.jdt.ls HOT 3 CLOSED

@Tachi107 , Yes exactly. I think if you're receiving the comment updates by e-mail, you don't see the subsequent edits I do. I updated once i discovered the lsp client mentioned ignores $/progress.

from eclipse.jdt.ls.

Yes, JDT-LS can certainly fix the issue.

The LSP spec defines https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#clientCapabilities :

window?: {
		/**
		 * It indicates whether the client supports server initiated
		 * progress using the `window/workDoneProgress/create` request.
		 *
		 * The capability also controls Whether client supports handling
		 * of progress notifications. If set servers are allowed to report a
		 * `workDoneProgress` property in the request specific server
		 * capabilities.
		 *
		 * @since 3.15.0
		 */
		workDoneProgress?: boolean;

So the value can be true, false, or null (optional).

JDT-LS should definitely handle the null the same way we would handle false.

The client could also work around the issue by setting workdoneProgress to false at https://github.com/yegappan/lsp/blob/38970403dc4d602056ea4028664206ffce74e82a/autoload/lsp/capabilities.vim . If the client supports this capability, they'll need to set it to true (not supported currently in the client).

@hopehadfield feel free to fix on our end.

from eclipse.jdt.ls.

from eclipse.jdt.ls.