Issues with Redeclaring Packages. Dublicates #48 about puppet-graphite HOT 12 CLOSED

Ok, i see the prob. If you have a good solution for arrays I will merge it happily :)

from puppet-graphite.

The defined function can be a pain in the ass, because if you have multipe defineds with different parameters. e.g. one installes

if ! defined(Package['gcc']) {
    package { 'gcc': ensure => installed }
  }

and another

if ! defined(Package['gcc']) {
    package { 'gcc': ensure => "4.2.3" }
  }

then its just luck which of them wins and will be executed.

So maybe the best way will be to just replace the package install part with an exec command like "yum -q -y install foo bar"

from puppet-graphite.

I would recommend adding a $manage_packages option to the main graphite class. This class is how the user decides if the graphite module is managing the packages (in the only-graphite use case) or if the packages will be managed outside the graphite class (more of a roles/profiles use case).

from puppet-graphite.

Agree with @nibalizer, I asked the guys on #puppet-dev and they said that the only real way of handling it

Alternatively, there's a method in https://github.com/puppetlabs/puppetlabs-stdlib to check an array of packages with ! defined(Package['foo']), more hacky though.

from puppet-graphite.

I wanted to experiment with Graphite today and hit this issue:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Duplicate declaration: Package[git] is already declared in file /etc/puppet/modules/graphite/manifests/install/redhat.pp:26;

from puppet-graphite.

So it looks like another module of yours already installs git. An easy workaround is just to remove the git package from the list of the packages to be install for redhat in the params.pp

from puppet-graphite.

I'd like to vote for the $manage_packages params.

I can easily exclude the offending module (it's part of my sysadmin::base role), but workarounds aren't long-term solutions :) I am already doing this in my test environment.

from puppet-graphite.

! defined() is not a good pattern as it is parse-order dependent.

from puppet-graphite.

#52

from puppet-graphite.

This issue should be solved with release 6.0.0. See #48 . At least for RedHat distros.

from puppet-graphite.

Their was a whole refactoring of the module since this is issue was created. Is it still up-to-date?

from puppet-graphite.

@dwerder Let me double check.

In the mean time, I'm making a basic Beaker test to check this scenario, PR coming soon! 👍

from puppet-graphite.