Comments (11)
Finally got around to retrying this - haven't got incremental code changes to work yet (waiting to see what comes of brendanzab/codespan#249), but Go To Definition works perfectly, thanks!
from tower-lsp.
Thanks for the kind words and feedback! Have you thought of using codespan and codespan-lsp, by any chance? The latter crate in particular should handle most of the conversions you describe, and it's what I personally use in my own LSP projects, including incremental text updates. With that said, I'm open to potentially "baking in" this sort of functionality into the project as an optional addition.
As for textDocument/typeDefinition
, I suppose that API addition will have to come in the next few releases. π
from tower-lsp.
Both textDocument/definition
and textDocument/typeDefinition
are on the list in #10. Hopefully I can knock them out over the next several days. If you would like to submit a pull request yourself, of course, that would also be most welcome.
from tower-lsp.
Thanks for the links to codespan
- didn't know about that. Since I wrote this I also discovered that rust-analyzer
has its LSP stuff as a generic crate. Here's an example. However they don't provide a nice trait like you do, so I'd definitely rather use this if it were complete.
from tower-lsp.
@Timmmm I've just merged in pull request #76, which implements goto declaration, goto definition, and goto type definition support. I hope to have a new release out on Crates.io fairly soon! Feel free to depend directly on the master
branch in the meantime, if your project allows it and you're eager to begin iterating.
from tower-lsp.
Ah cool, thanks! I'll give it a go.
from tower-lsp.
@Timmmm Please alert me to any glaring issues come up before the next release! I'll do my best to get in some quick fixes before publishing to Crates.io, if deemed necessary.
from tower-lsp.
@Timmmm Version 0.6.0 has just been published to Crates.io with support for goto declaration, goto definition, and goto type definition.
from tower-lsp.
We are currently depending on an old version of lsp-types
(0.68 vs. 0.70, at the time of writing) because codespan-lsp
hasn't been updated to support the latest version of lsp-types
(see brendanzab/codespan#163). Once this is updated, I think we can update our lsp-types
dependency to the latest version and close this issue as invalid.
from tower-lsp.
Closed by #105, which gives us access to the latest lsp-types
and therefore compatibility with the latest codespan-lsp
.
from tower-lsp.
@Timmmm That's fantastic news! Glad it works for you. π€ I'm still waiting to see what the future of codespan
will actually be, given that @brendanzab has been refactoring the repo quite a bit. I'm sure some solution for your needs will still exist though.
from tower-lsp.
Related Issues (20)
- Restrict JSON-RPC request/notification params to objects and arrays HOT 2
- Concurrent requests without `Send` requirement for single threaded runtimes HOT 8
- Notification methods return Invalid request HOT 6
- Split the generic lsp-like backend from the lsp-specific implementation HOT 2
- Allow custom methods to override default method signature HOT 2
- Layer example does not work? HOT 5
- Server may not be exiting correctly after receiving `exit` notification HOT 3
- Try `lsprotocol` as the LSP types provider dependency
- Re-export `serde_json::Value` HOT 1
- Won't Compile HOT 2
- custom methods for notification without params not called HOT 6
- Header must provide a Content-Length property HOT 3
- Add `RequestFailed` and `ServerCancelled` LSP specific error codes?
- unreachable panicked in tower-lsp HOT 1
- Panic on future cancellation HOT 2
- how to shutdown server safely?
- ID placement in messages
- Question: `tracing_subscriber::fmt()` in examples
- "exit" notification doesn't seem to be correctly handled
- method `diagnostic` has an incompatible type for trait HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tower-lsp.