Improve entity_field Twig_Function for entities with a custom primary key about easyadminbundle HOT 5 CLOSED

Can't we inject the configurator inside this twig extension and check the entity config in order to retrieve the primary key value ?

from easyadminbundle.

Yes, that's the main solution.
I opened this issue because I wonder if this worth the dependency, as the workaround is pretty easy, and a getId method on an entity isn't a non-sense anyway.

from easyadminbundle.

I think that injecting the configurator in the twig extension might be right, as it's also probably the best way to get the whole entities list and make it a "view-accessible" property, instead of passing it as parameter from the controller (which is kind boring when extending the AdminController).

Sounds good to me to add this dependency to the twig extension :)

tag @javiereguiluz

from easyadminbundle.

I'm going to think about this issue because it looks wrong to provide support for non-id primary keys and then, don't make this little extra effort to provide cool links for associations.

from easyadminbundle.

Did not make a PR for now, but here is what was ready to be done considering this issue.
Maybe it'll be helpful.

I'm not fan of the try/catch, but simple way to keep something to display if the entity isn't configured to be used in the bundle, and avoiding generating broken link as currently.

I think it would be helpful to handle the fact the entity isn't present in the bundle configuration in the getEntityConfiguration method. (returning null and avoid triggering exceptions)

from easyadminbundle.