Comments (3)
It might be worth considering variable names that have units, e.g., rx_rates_per_cc_per_s
, washout_rates_per_s
.
from mam4xx.
Just to follow up on this some -- I went through the Fortran version of the code more carefully (specifically subroutine gas_phase_chemdr, variable reaction_rates), tracking down the origin of the relevant equations. I found the following: 1) at least all of the chemical reaction elements of this array seem to have the same units with each other at any given time; 2) however, the units of all these elements do change multiple times over the coarse of this subroutine. Specifically, they start off (after the call to setrxt) as cm^3 / (molecule -- s) (i.e., like a reaction rate constant for a second-order reaction), but after the call to adjrxt they become s^{-1}; then during the call to rate_diags_calc they become molecules / (cm^3 - s).
from mam4xx.
Thank you for looking into this, Brian! That certainly provides some peace of mind.
And, based on this, it appears that the arrays carrying quantities and rates likely contain entries with heterogeneous units. As such, this should be looked into after porting is complete/validated and we can modify/improve the code.
edit: follow-up thoughts
from mam4xx.
Related Issues (20)
- Working notes: EAMxx aerosol microphysics AtmosphereProcess HOT 2
- Error Handling and Logging within Kernels HOT 3
- Scalable File I/O capability for emissions, etc HOT 2
- Missing file and compilation error in EAMxx HOT 1
- Inter-level dependencies of note
- inv_density matrix in calcsize.
- Deception CI double precision GPU build failing HOT 10
- `validate_aer_rad_props_lw_ts_355` test failing on GPU HOT 7
- Make mam4xx buildable within a subdirectory of a host project HOT 1
- Potential Race Condition
- MAM4xx sycl errors in relative_humidity_from_vapor_mixing_ratio
- MAM4xx warnings in emaxx
- Using .data() in source code.
- Update the `WetDeposition::compute_tendencies` routine
- Repeated use of model index while fetching mixing ratios.
- Validation Still Required for 2 `mo_drydep` Functions
- Building MAM4xx and Haero without openmp flag.
- Finish remaining validation tests for `aero_model_emissions`
- Create unit tests for `aero_model_emissions`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mam4xx.