Git Product home page Git Product logo

Comments (6)

bool-dev avatar bool-dev commented on August 18, 2024

👍

from flask-s3.

Fuyukai avatar Fuyukai commented on August 18, 2024

Unfortunately, this would break backwards compatibility, and as most users probably don't pin their dependency versions, it would break their things.

from flask-s3.

bool-dev avatar bool-dev commented on August 18, 2024

@SunDwarf how about throwing deprecation warnings, and falling back to old naming structure if new structure is not used? I'd be happy to spend some time over the weekend and send a pull request.
(I also have some variables in my config starting with S3_ but thankfully no conflicts!)

from flask-s3.

mafrosis avatar mafrosis commented on August 18, 2024

I was thinking of @bool-dev's approach as well (which is how Django handle's this kind of thing). Support both variable names, and show deprecation warnings until the next major release.

from flask-s3.

Fuyukai avatar Fuyukai commented on August 18, 2024

I think that's a better idea.

from flask-s3.

mafrosis avatar mafrosis commented on August 18, 2024

@SunDwarf We definitely can't just change the names of the config variables on everyone! ;)

from flask-s3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.