no need to parse json if headers are correctly set ? about jquery-autocomplete HOT 5 CLOSED

correct, will fix

On Tue, Feb 14, 2012 at 18:25, zack
[email protected]
wrote:

with remoteDataType: 'json'

• was getting error 'results is null', the following fix worked for me
  .. I dont believe its necessary to parse json if the content headers are set correctly

$.Autocompleter.prototype.parseRemoteData = function(remoteData) {        var remoteDataType = this.options.remoteDataType;        if (remoteDataType === 'json') {            //return $.parseJSON(remoteData);  // not needed?            return remoteData;        }        return plainTextParser(remoteData, this.options.lineSeparator, this.options.cellSeparator);    };

---

Reply to this email directly or view it on GitHub:
#15

from jquery-autocomplete.

ah btw, just ran into another related issue..

found I needed to explicity set contentType: "application/json; charset=utf-8"

• possibly this is a bug with jquery1.6.4
• docs state that contentType gets set automatically, but in my case no contentType header was being sent

from jquery-autocomplete.

I think I'll just revert to always using text and manually parsing
json through $.parseJSON, has always worked well, except for setting
content headers

On Tue, Feb 14, 2012 at 19:20, zack
[email protected]
wrote:

ah btw, just ran into another related issue..

found I needed to explicity set contentType: "application/json; charset=utf-8"

• possibly this is a bug with jquery1.6.4
• docs state that contentType gets set automatically, but in my case no contentType header was being sent

---

Reply to this email directly or view it on GitHub:
#15 (comment)

from jquery-autocomplete.

yeah, but if the headers are set correctly for json its parsed automatically by jquery.ajax

..and if they are not set correctly for json.. there will be problems if the backend is expecting correct json headers

from jquery-autocomplete.

btw my previous comment about 'explicity setting contentType' was not relevant, due to a mis-understanding of http headers more than anything:

• setting Content-Type header on a GET request is not required (jquery does not set it - as I noted before),
• Accept header should be sufficient to indicate that the required response type should be e.g. application/json

from jquery-autocomplete.