-Werror=restrict with gcc-12 -std=c++2{0,3} about dyninst HOT 2 OPEN

Yes, I'd say it's a compiler bug. Without -Werror there are 14 of these. They all involve a std::string operation that has a char * literal argument. There are 3 at lines 154, 161, and 162 of the files parseAPI/src/ProbabilisticParser.C below. Not clear why 156 didn't trigger the problem, but most the c-string literals that trigger the warning are small (1 maybe 2 bytes plus the NULL). Most of the warnings are of the form of lines 161 and 162 where the string literal is passed as the lhs and a std::string as the rhs to std::string::operator+.

151 string IdiomTerm::human_format() const {
152     string entryname;
153     if(*this == WILDCARD_TERM)
154         entryname = "*";
155     else if(entryNames_IAPI.find((entryID)(entry_id)) == entryNames_IAPI.end()    ) { 
156         entryname = "[UNMAPED]";
157         fprintf(stderr, "Found entryID not mapped in entryNames_IAPI %d\n", en    try_id);
158     }
159     else {
160         entryname = entryNames_IAPI[(entryID)(entry_id)];
161         if (arg1 != NOARG) entryname += " " + HandleAnOperand(arg1, 1);
162         if (arg2 != NOARG) entryname += "," + HandleAnOperand(arg2, 1);
163     }
164 
165     return entryname;
166 
167 }

from dyninst.

RELEASE build on fedora 38 using g++ version 13 and C++20 builds without warning.

from dyninst.