Git Product home page Git Product logo

Comments (10)

adamthedeveloper avatar adamthedeveloper commented on May 26, 2024 2

I forked the project, commented that Xml line out and changed the version
dependency to >= 4. I also had to fix a null pointer exception to get
around the nil.include? issue that kept popping up if there were no tables
to start with. Take a look at the fork for adamthedeveloper to see the
changes I had to make. I don't know what the impacts of removing the Xml
requirement are yet, however the Gem is working for me now with Rails 5.
On Thu, Feb 25, 2016 at 6:55 AM Abhishek Patel [email protected]
wrote:

I think this is breaking because of include ActiveModel::Serializers::Xml
in Dynamoid::Components.

Also latest version depends on active_model ~> 4, Any idea when
active_model(rails) 5 will be supported?


Reply to this email directly or view it on GitHub
#43 (comment).

from dynamoid.

abhi-patel avatar abhi-patel commented on May 26, 2024

Same here.

from dynamoid.

abhi-patel avatar abhi-patel commented on May 26, 2024

I think this is breaking because of include ActiveModel::Serializers::Xml in Dynamoid::Components.

Also latest version depends on active_model ~> 4, Any idea when active_model(rails) 5 will be supported?

from dynamoid.

cignoir avatar cignoir commented on May 26, 2024

+1
Currently, adamthedeveloper/Dynamoid works fine for me in Rails5.
I will report if it breaks.

from dynamoid.

VGleb avatar VGleb commented on May 26, 2024

+1
adamthedeveloper/Dynamoid works in Rails 5.0.0.beta3

from dynamoid.

cavi21 avatar cavi21 commented on May 26, 2024

Hey everyone, there is PR #63 opened for this, if anyone has more insight of the issue in order to build a test case for it, it would be great! Happy to do it, or discuss it

from dynamoid.

josephverbeck avatar josephverbeck commented on May 26, 2024

I also forked the project and worked with the new activemodel-serializers-xml gem to not remove the include ActiveModel::Serializers::Xml from the components.rb file. This also required updating the activemodel dependency to 5.0.0.beta3. Hopefully this helps someone else

from dynamoid.

xdougx avatar xdougx commented on May 26, 2024

Is there any changes on dynamoid repository?

from dynamoid.

pboling avatar pboling commented on May 26, 2024

@xdougx There is at least one PR that attempts to address this. None of them has been accepted yet, and all are failing the build and are waiting on someone to rebase them on latest master (master build is green again!)

from dynamoid.

pboling avatar pboling commented on May 26, 2024

Rails 5 support is done.

from dynamoid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.