Git Product home page Git Product logo

Comments (1)

DY112 avatar DY112 commented on August 21, 2024

Hi, @0Error0Warning, thank you for your interest about my work.
I saw that issue in my repo, but I’ve been quite busy these days to have time to answer the issue.
I am sorry about that :(

I think that there is a slight difference between two visualization process.

In 1_make_mixture_map.py, the white balance process is done by following steps.

  1. Open raw image using rawpy (Directly open RAW file, not using DCRAW or Tiff)
  2. Apply WB using illumination map, directly accessing to raw_image_array in RawPy instance (apply_wb_raw function, line 194)
  3. Visualize sRGB image using postprocess function
    So [open RAW → direct WB application → postprocess]

In visualize.py,

  1. GT tiff file is generated through [ Tiff conversion using DCRAW → WB application → saved as Tiff ]
  2. To visualize tiff file into sRGB, we utilize fake raw file and copy pixels into RAW instance
  3. Visualize sRGB image using postprocess function
    So [Tiff conversion using DCRAW → WB application in Tiff → overwrite pixels into fake RAW instance → postprocess]

You can compare the differences in these processes and explore where the differences in values occur.
You can compare the value of raw_image after opening the RAW image with Rawpy with the value saved as a TIFF file using DCRAW.
However, sRGB images are images that have undergone a lot of post-processing, so if you use images that are visualized according to one criterion, there should be no problem.
For white balance research, the sRGB image is for reference only. If you want to compare the correct values, please use the values in the RAW domain.
The pixel values in the dataset I provide are all provided in TIFF format using DCRAW, so they will have consistent values.

from lsmi-dataset.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.