Feat: Filenames on `S3` should be the `cid` of the content ... about imgup HOT 6 CLOSED

Because the current code used in the LiveView make the upload from Javascript (followed by the File Upload guide in https://hexdocs.pm/phoenix_live_view/uploads.html), because it's been requested that the LiveView uses the upload/1 function that was implemented, I'm going to create a new page to use LiveView but use this function. I'm not going to refactor the code of the pre-existing LiveView because it would essentially be overhauled.

In order to not lose the previous work made, I'm going to create a new page that is "clientless", which uses the upload/1 function that was implemented.

from imgup.

The closed PR #64 directly addresses this. It generates the CID from the contents of the file within the JS code.
Because using JS to push the file was not initially intended, I closed off the PR. If relevant, I might open it back up again to finish it.

from imgup.

And yes, I'm doing the "clientless" version now on a different live view page. I want to get this done before doing other issues (like the image classifier) so I can have a more solid foundation to work on it.

I'm branching off from #86 (review) so I don't have merge conflicts later on 👌

from imgup.

With the changes introduced in

from imgup.

The upload.ex is only used for the API.

from imgup.

Indeed the guide written by Chris https://github.com/phoenixframework/phoenix_live_view/blob/v0.19.3/guides/server/uploads.md#L1 uses the JS "direct" uploads method with signing. That is preferable in certain circumstances. If we can read the contents of the file on the device/browser we could use the JS implementation of CID to create the filename and thus continue using the direct upload approach. But I find that it requires considerably more code and isn't well tested. 💭

If you end up making a "clientless" version that uses the upload/1 function, please document + test as much as possible. 🙏

from imgup.