YT code is loaded even if there is no video about gtm4wp HOT 5 CLOSED

Here you are: f3fa210

from gtm4wp.

Script is loaded from here:
https://github.com/duracelltomi/gtm4wp/blob/master/js/gtm4wp-youtube.js

What I could imagine is to add a dom ready listener and then look at YT iframes in the DOM and only load this code if there are any YT embeds.

from gtm4wp.

I can imagine loading that file with something like this:

function gtm4wp_load_youtube_script() {
  global $post;
  if (has_block('core-embed/youtube', $post) || (strpos($post->post_content, '<iframe') !== false && strpos($post->post_content, 'youtu') !== false)) {
    wp_enqueue_script('gtm4wp-youtube');
  }
}
add_action('wp_enqueue_scripts', 'gtm4wp_load_youtube_script');

from gtm4wp.

I am not sure the performance of this code will be good. It scans through the whole post content on the server side increasing processing time and thus, response time.

Checking this in the browser seems to be a better solution for me.

from gtm4wp.

Yes this will definitely put some load on the server, but I believe every WP site now uses some kind of caching - if not, PSI is looking bad and those numbers matter to managers :) So if it's checked on server and then saved in cache in pure html (W3TC, Super Cache, WP Rocket..) it shouldn't add load on server anymore.
I don't like additional scripts because JS is still single threaded and it can block execution of other JS. I'm pretty bad in JS, so I just avoid using JS whenever possible, because when I use it, it has impact on performance - mostly on mobiles.

from gtm4wp.