Find out why DoHealthCheck() Fails about duo_universal_csharp HOT 4 OPEN

@JoelDKraft We got the same request from an internal Duo team that uses this client, which led to 1d94501 which is not in a release yet. Does that change look like it would suit your use case? If so, I can work on getting a release out soon.

from duo_universal_csharp.

That takes care of half of what I described, which is being able to determine if there was an HTTP exception thrown by the API call. If there is no exception, but the API returns FAIL, that is information is still not available.

Now that you've added that parameter, maybe it makes sense to throw a DuoException when the health check comes back negative, as well?

 var response = await DoPost<HealthCheckResponse>(healthCheckUrl, parameters);
 if (response.Stat == "OK") return true;
 if (!handleException) throw new DuoException($"{response.Code} {response.Message} {response.MessageDetail}");
return false;

from duo_universal_csharp.

@JoelDKraft thanks for the clarification. I'll look into it.

from duo_universal_csharp.

I'm going to throw one more comment in here: the same type of thing happens in DoPost.

The following line throws an exception if the call does not return a 200 code...
// This will throw an HttpRequestException if the result code is not in the 200s
//httpResponse.EnsureSuccessStatusCode();

So in my case, I got the following exception:
Response status code does not indicate success: 400 (Bad Request)

The problem here is that the API actually returned a response with an error message, and I really needed to know that response to figure out what was going wrong. But this blanket exception again removed any chance of me seeing that underlying error.

Replacing it with something like this would let you actually see the API response.
if (!httpResponse.IsSuccessStatusCode) throw new DuoException($"{httpResponse.StatusCode}: {httpResponse.Content.ReadAsStringAsync().Result}");

I was able to get this server response, and now I know what is wrong:
{"error": "invalid_grant", "error_description": "The provided authorization grant (e.g., authorization code) or refresh token is invalid, expired, revoked, does not match the redirection URI used in the authorization request, or was issued to another client."}

I would probably not just dump in the raw JSON, but you get the idea...

from duo_universal_csharp.