Git Product home page Git Product logo

Comments (5)

ajkerrigan avatar ajkerrigan commented on September 13, 2024 1

Ok perfect, sounds good. If you want a hand (or at least a sounding board for ideas) feel free to hit me up here or on og-aws.

And in case it ends up being relevant, I pushed up some local tweaks here. I don't think the changes make enough of a difference to warrant a merge as-is (and would need some cleanup/tests), but some of the tweaks might be useful elsewhere.

from cloudtracker.

0xdabbad00 avatar 0xdabbad00 commented on September 13, 2024 1

I'm unfortunately not going to focus on any work in this project for creating Athena things, and should instead focus on creating Athena partitions in https://github.com/duo-labs/cloudtrail-partitioner

from cloudtracker.

ajkerrigan avatar ajkerrigan commented on September 13, 2024

Thanks for the direct link! I'll have a look at that, and see about condensing those queries (without impacting the functionality).

from cloudtracker.

ajkerrigan avatar ajkerrigan commented on September 13, 2024

I read through this code, and I'm going to back away and touch nothing. You're already adding multiple partitions per call, just looks like you're batching by month. That seems perfectly reasonable given the partition volume. I don't want my first contribution to be blowing stuff up for no good reason, so I'll just say thanks for a nifty product!

from cloudtracker.

0xdabbad00 avatar 0xdabbad00 commented on September 13, 2024

I think there are some improvements can be made based on your idea. I'll keep this ticket open and look into it further at some point when I focus on this project again. I've been told AWS is going to document CloudTrail better and I have some plans for leveraging AWS's Client Side Monitoring that will push me into focusing on this project again more.

from cloudtracker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.