Sorting by price is broken when using a comma separator about theouterrim HOT 9 CLOSED

I'll get started on this, at least the data for now. I'm not sure I want to make any changes to the tables themselves if we're going to merge in the mui-datatables pr soon.

Example:

from theouterrim.

What I'm thinking so far is that the restricted value will be another hidden column (like generatedId), we'll give the price columns a custom renderer that conditionally prepends (R) on restricted items, and I'm hoping that the sorting will be done based on the data value and not the display value. If not, a custom sort function should handle that.

from theouterrim.

Let me see if I can get you a screenshot:

from theouterrim.

Yeah, that's very broken, thanks.

from theouterrim.

Excellent! Thanks for snapping up another issue. As soon as I finished poking around at the new table, we'll get that in.

I look forward to your solution on the (R) issue here. Whatever you come up with could also be used in #45 with + for some weapons.

from theouterrim.

Got this working, though it looks like the table wants to break the price column once you have more than 4 digits in the price, like this:

Is this something we care to fix? Should be possible to just change the word-breaking css. I've also noticed that a lot of column seem to break annoyingly leading to some items, like weapons with lots of qualities or anything that's in all the core books, ending up 5-6 rows tall. We could just make nothing break, though that would probably significantly widen most of the tables.

UPDATE: Actually, looks like the wrapping depends on what else is there, as the table lets the columns determine their widths dynamically. I have no idea what logic the table itself uses to determine how wide the table as a whole should be, but I have a feeling it might depend on how wrappable the column values themselves are. Something like the Special column on the Weapons table wraps to almost 1 entry per line, whereas the starships table has less easily-wrapped column, so the whole thing ends up wider.

from theouterrim.

Very cool that you got this working.

I think we're fine just leaving the wrapping as it is, considering the dynamism of it. If it ends up being really annoying we can revisit it.

from theouterrim.

Sounds good, once #52 is merged I'll open the PR for this

from theouterrim.

Awesome, merged.

from theouterrim.