Git Product home page Git Product logo

Comments (5)

arielsalminen avatar arielsalminen commented on July 22, 2024

@aardrian Thank you for reporting this! I think we may have a fix for this coming soon-ish. We thought we already fixed this, but seems like it’s still an issue in some readers.

from date-picker.

WickyNilliams avatar WickyNilliams commented on July 22, 2024

Was able to reproduce this in both JAWS and NVDA. VoiceOver does announce the region. Not sure why it is not getting announced in the others. I tried to fix by leaving the region blank until the picker is open (hoping that the screen readers would then see the text change, and then announce), but that didn't work either.

TBH live region kind of feels like the wrong choice here. It's not really live/dynamic, the content is static. But I'm unsure what would be more apporpriate

from date-picker.

WickyNilliams avatar WickyNilliams commented on July 22, 2024

@aardrian I'm just going back through these issues. If you remember, we eventually settled on using a plain ol' table (rather than role="grid") for the calendar, so i'm thinking this help text is now redundant, since table navigation commands will be the standard for screen reader users rather than our custom keyboard shortcuts. What do you think? Should I drop it?

from date-picker.

aardrian avatar aardrian commented on July 22, 2024

@WickyNilliams I don't recall the instructions in place now, but if it is a table, announces as a table, and supports native table navigation in the screen reader, then there is no need to tell the screen reader user how to navigate it.

from date-picker.

WickyNilliams avatar WickyNilliams commented on July 22, 2024

OK thanks, that was my intuition.

It says "You can use arrow keys to navigate dates". This was true when we previously used the grid role since key presses get passed through to our code, but now it's a plain table the advice isn't just unnecessary, it's wrong!

I'll remove it and resolve this bug that way :)

from date-picker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.