Flash version doesn't show the last 3 numbers. about zeroclickinfo-spice HOT 8 CLOSED

@zekiel Downside to this is that the user would have to download more content to get it working because we have to use some other library which we're not currently planning on using: https://code.google.com/p/swfobject/

I think we should just tolerate this. @sdougbrown @bsstoner any opinion on this?

from zeroclickinfo-spice.

Whoa, I didn't realize we were building FlashDetect into core. Is it used for anything else besides this spice? Can we remove and just add to this spice?

You can get the full version without a lib. It's like 20-30 lines of code for cross-browser detection. Something like this in Chrome/FF: navigator.mimeTypes["application/x-shockwave-flash"].enabledPlugin It's a little more verbose in IE.

from zeroclickinfo-spice.

@bsstoner Yup, we can do that too, but I thought I should take advantage of FlashDetect since it's already there. It's not used in any other Spice, and a quick grep in the core repo didn't show anything. We should probably move it out of there then.

from zeroclickinfo-spice.

not my area of expertise :) defaulting to your judgement

http://i.imgur.com/50iWAFW.gif

from zeroclickinfo-spice.

@jagtalon @zekiel @bsstoner Seems like this can be closed then?

from zeroclickinfo-spice.

@javathunderman I don't think we've resolved it yet, so we should keep it open.

from zeroclickinfo-spice.

Fixed in #2373

from zeroclickinfo-spice.

@MrChrisW nice 👍

from zeroclickinfo-spice.