Make sure Spice IA's check for a remainder (where applicable) about zeroclickinfo-spice HOT 12 CLOSED

CanIStreamIt is down at the moment: http://www.canistream.it/ddg/query/The%20Loneliest%20Planet

from zeroclickinfo-spice.

Yup I already emailed them, they're currently fixing it. Thanks for the heads up though!

from zeroclickinfo-spice.

Are there any problem cases for this or was it just the down time?

from zeroclickinfo-spice.

@nospampleasemam just down time. Keep it open for now until its working again (as a reminder)

from zeroclickinfo-spice.

@nospampleasemam @moollaza it's up now.

from zeroclickinfo-spice.

I think it checks if the remainder is defined or non-empty: https://github.com/duckduckgo/zeroclickinfo-spice/blob/master/lib/DDG/Spice/Canistreamit.pm#L32

return unless $remainder =~ /^(?:can\s*i?|how\s*to|where\s*(?:to|can\s+i))?\s*(?:find\s+a)?\s*(.+)$/i;

from zeroclickinfo-spice.

My mistake, this should still be open until we've gone through all the spice IA's

from zeroclickinfo-spice.

This is still an issue for a few Spice IA's:

Bitcoin for example does not make sure a remainder is defined - https://github.com/duckduckgo/zeroclickinfo-spice/blob/master/lib/DDG/Spice/Bitcoin.pm#L24

from zeroclickinfo-spice.

Also the Maven spice: https://github.com/duckduckgo/zeroclickinfo-spice/blob/master/lib/DDG/Spice/Maven.pm?source=c#L15

from zeroclickinfo-spice.

I can take a look at this issue if nobody takes it.

from zeroclickinfo-spice.

@moollaza The Bitcoin Spice does the checking on the JS side (because, from what I understand, the list of currencies can change.) @heytitle If you'd like to take a look at Maven, go on right ahead. :)

from zeroclickinfo-spice.

Closed by #1000

from zeroclickinfo-spice.