Comments (8)
@jagtalon the reason for multiple spice calls is because zipcode (and possibly octopart) are in the non-exclusive block which lets them race against other spices (because the query space for anything in non-exclusive is supposed to be large) hence zipcode is triggering because the ne5555 matches the regex looking for a possible postal code which is essentially a comobo of numbers and letters, however it fails over to octopart which then gives the result. As for the older version of occtopart triggering that seems like its a bigger issue so we should ask @yegg why that is happening. Any ideas Gabe?
from zeroclickinfo-spice.
I'm looking at Firebug on those queries and not seeing the old version. Was this the deep trigger you were testing on your machine or something?
As for multiple triggers, @moollaza is right about that. Generally, it isn't bad and they fire in parallel. However, if there are large cases where it is triggering when it shouldn't be then we can reign in the trigger with a qualifying regex. In this case zip code seems to be triggering on
https://www.duckduckgo.com/js/spice/zipcode/NE555/datasheet
And maybe it shouldn't be (given datasheet) but I haven't looked too closely.
We can generally check for false positives by seeing what queries it is triggering on in the back end. I can show you how to do that if (either of) you want to look into it.
from zeroclickinfo-spice.
@yegg @moollaza Thanks! It's much clearer now. I thought non-exclusive plugins only trigger if plugins in other categories (spice, exclusive, etc.) didn't. I'll see if the same thing happens with other plugins.
I'm using the latest version of deep (in the master branch), and it's not modified in any way. I tried Firebug and it's still there (try searching 121):
https://saucelabs.com/tests/18e867aa78014eb79626cbb212559945
https://saucelabs.com/tests/c4001e5b039f44ab807485c931a1f197#
from zeroclickinfo-spice.
Are you seeing this on the main site? I'm looking at
https://duckduckgo.com/?q=ne555+datasheet
and not seeing it.
from zeroclickinfo-spice.
@yegg sorry you are correct, I didn't realize @jagtalon 's links were to his dev instance. I believe the reason you are seeing the duplicate spice then Jag is because the newest version, 128, was deployed on your instance by yourself, however older versions of the octopart spice stay on your instance (we don't remove the perl modules) and I'm guessing that the newer octopart spice triggers differently, because I see two spice calls to octopart: "ne555" and "ne555%20datasheet" so I think both versions, because they are different are each triggering. I might be mistaken though. This might be a question for @Getty.
from zeroclickinfo-spice.
@moollaza @yegg Whoops. I'm sorry, I forgot to mention that it only happens to my dev machine. I don't get that either because I just updated triggers any => "datasheet", "specs"
to triggers any => "datasheet", "specs", "octopart";
from zeroclickinfo-spice.
Look in source to see who is calling it.
from zeroclickinfo-spice.
Is this resolved? I do not see it on your dev node.
from zeroclickinfo-spice.
Related Issues (20)
- Location Sunrise/Sunset: HOT 2
- Instant answer feature not working for all stocks HOT 1
- Word definitions can't be copied HOT 1
- Translation: Instant answer doesn't work HOT 4
- Quote Of The Day: HOT 1
- BrainyQuote:
- Congress: HOT 1
- Amazon:
- Editor: doesnt show up after searching "editor" HOT 1
- Currency Conversion: HOT 3
- BBC: Access is currently only available to BBC employees HOT 1
- Actor Filmography: queries do not work HOT 1
- NFL Games: Suggestion: Add timezone info
- Actor Filmography: HOT 1
- Editor: not working HOT 3
- Translation Suggestion: Amazon Translate as upstream provider HOT 2
- Dictionary Definition:
- Currency Conversion Not Working HOT 2
- Amazon: HOT 1
- Cryptocurrency: Not rendering IA results HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zeroclickinfo-spice.