Comments (7)
Discussion opened at https://npm.community/t/allow-any-one-of-specified-packages-in-peerdependencies/4933
from solium-plugin-security.
Hey @pcowgill sorry for late response, yes this is the ideal solution, but unfortunately I don't have the bandwidth to change this, because this requires huge changes in this repo as well as some changes & tests in core ethlint (to allow reading npm modules prefixed with ethlint-plugin-
, currently it can only read solium-plugin-
)
from solium-plugin-security.
@duaraghav8 Totally understandable. Thanks for getting back to me!
from solium-plugin-security.
Great point @zachlysobey
I just confirmed from docs and the actual code that there is unfortunately no way to specify an OR condition in peer deps.
I'll open up an issue with NPM. Until an OR is possible, I'll add this caveat to the Docs.
I don't want to change the peer dep from solium
to ethlint
right now because it could be breaking for anyone who treats warnings as errors too.
I'm open to hearing any suggestions you have on solving this problem.
Please ignore the warning for now.
from solium-plugin-security.
(This comment is for my own future reference)
Issue has been added to Blocked Tasks.
Once OR is available:
- Modify security plugin to use it
- Remove caveat from plugin's doc as well as Ethlint docs
- Modify Ethlint Dev doc to inform reader to use this OR feature in peer deps to specify both
solium
andethlint
.
from solium-plugin-security.
@duaraghav8 What about renaming this repo to ethlint-plugin-security
and publishing to npm from the main feature branch a new package named ethlint-plugin-security
with a peer deep of ethlint
, and from a legacy feature branch publishing the old package named solium-plugin-security
with the existing peer dep?
from solium-plugin-security.
@duaraghav8 What about renaming this repo to
ethlint-plugin-security
and publishing to npm from the main feature branch a new package namedethlint-plugin-security
with a peer deep ofethlint
, and from a legacy feature branch publishing the old package namedsolium-plugin-security
with the existing peer dep?
Do you think this would be a workable solution? Thanks!
from solium-plugin-security.
Related Issues (9)
- no-call-value: recommend only 'transfer' not 'send'
- TODO HOT 3
- Keeping track of Bounty Rules
- npm test causing SyntaxError HOT 3
- plugin can only use solium v1.0.0 as dev dep (no other versions) HOT 1
- Error on new security rules HOT 2
- failures in travis: Unable to load Plugin HOT 1
- Question concerning rules to enable HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from solium-plugin-security.