Problem with table locks since PR #8 about backup-all-mysql HOT 7 CLOSED

Oh I think .

And If I convert

CURRENT_OPTS="$CURRENT_OPTS --lock-tables";

to

CURRENT_OPTS="--lock-tables $CURRENT_OPTS";

Your option will be after the --lock-tables ? And resolve the error ? ( did you see a problem ? )

from backup-all-mysql.

@thib3113 what do you think about this?

from backup-all-mysql.

Two ideas to solve the problem:

1. handle MYSQLDUMP_ADD_OPTS within the loop to add it after --lock-tables
2. add a special LOCK_TABLES env var. The default is 1. So in my case, I could set it to 0.

I'd prefer the second one as it seems cleaner to me.

@thib3113 Do you have the time to submit a fix?

from backup-all-mysql.

I prefer the 1/ .

Because the second one can maybe break things ( like if you need to add OPTS after the --lock-tables ), and will always show a warning if we lock the tables mysql ( If we clean the loop ) .

else, 3/ instead of adding --lock-table when the table is mysql, we maybe can add --skip-lock-tables if the table is mysql ?
So, In you case, you will get two time --skip-lock-tables ( this maybe need some tests with a big db :/ )

from backup-all-mysql.

Ok. I see the argument about 2. And I don't like 3.

So let's take 1?

from backup-all-mysql.

Ok for me .

Just for the moment, I can't do it for the moment ( like not today, maybe not tomorrow ) .
Because I'll need to recreate repository / docker hub .... to test .

in the other way, I understand you need it asap for yours backups :/ .

from backup-all-mysql.

Seems a simple and good idea 😀

from backup-all-mysql.