PhysicalPort incomplete about py-capellambse HOT 3 CLOSED

alternatively, the PhysicalLinks could be shown for PhysicalComponent, and a list is provisioned in the data structure but erroneously empty. Which is a bug in my understanding.

from py-capellambse.

You can see port from the on the link ends but not the links on the port? oh that should be super easy to add, we do that for component and function ports - I guess we didn't walk into that need on the PA somehow (cable BOM app iterated on links anyways). Since you wanted to try making a simple improvement - this might be a nice candidate. Would you like to try adding it yourself, @malnemark, or should we look into it?

if you look at component port implementation, the class itself has exchanges property typed as c.Accessor:

The accessor is set at the end of the module for ComponentPort and all other ports in one go:

you can basically do the same in cs module (https://github.com/DSD-DBS/py-capellambse/blob/0841fd7549c06860de16f7e7f719582d9aad0432/capellambse/model/crosslayer/cs.py) on PhysicalPort - add a property and set accessor later, similar to the ComponentPort example

from py-capellambse.

I checked: only the exchanges attribute in PhysicalPort is missing (cs.py, below line 66 ).

The accessor setting is done at cs.py lines 163 ff.

Please go ahead with the fix, I won't be able to in the next days..

from py-capellambse.