PhysicalPath parameter not consistent in xWebsite about webadministrationdsc HOT 5 CLOSED

Fortunately this is an easy fix, unfortunately we don't have much in the way of unit testing on this module so it'll take more time to bootstrap up the test infastructure then it will to actually correct the problem. 😀

What we should decide on is if it should be required or not.

If we change the mof file to Required (which would remove the warning) we'd have to add it to the Get-TargetResource which personally I find a bit gross as we don't actually use the physical path.

If we actually remove the required parameter on the file we then have no way of enforcing (short of checking that the variable is null and throwing, which makes me think it should just be required. So I guess adding it to Get-TargetResource is the "better" option?

from webadministrationdsc.

I agree with @tysonjhayes final analysis. Physical-Path should be required. Perhaps it's an issue in DSC that anything other than the key properties are required for Get-TargetResource. Theoretically, only the key properties should be needed to get the resources.

from webadministrationdsc.

@TravisEz13 I've got a fix for this already and can copy/paste some of my tests from xNetworking to get this going pretty quickly. Should have something I can give back by tomorrow or so (assuming appveyor plays nice with me).

from webadministrationdsc.

OK so this is actually blocked on xDSCResourceDesigner having a bug in the embedded classes. This is fixed in the cDSCResourceDesigner. So I won't be able to test this until the bug in xDSCResourceDesigner is fixed. @TravisEz13 do we want to wait until xDSCResourceDesigner is fixed for me to submit this or should I go ahead?

from webadministrationdsc.

blocked because you cannot write proper tests?

How about we add placeholder tests for the resource designer tests and add a test that tries to calls a configuration without the parameter, and verify it throws. Example with the Registry Resource, and the ValueName parameter missing:

Describe -Name 'Example' -Fixture {
    it -name 'ExampleIt' -test {

           configuration ExampleConfig
            {
                Import-DscResource –ModuleName ’PSDesiredStateConfiguration’
                Registry ExampleFile
                {
                    Key = 'keyExample'
                }
            }

        {
            ExampleConfig

        } | should throw "Errors occurred while processing configuration 'ExampleConfig'."
    }
}

from webadministrationdsc.