Git Product home page Git Product logo

Comments (6)

nepalez avatar nepalez commented on July 27, 2024

@bjeanes Hi! Thank you, you're right
Will restore it on weekend

from dry-initializer.

bjeanes avatar bjeanes commented on July 27, 2024

Hi @nepalez just a casual and hopefully friendly reminder about this one. I'd offer to help but at this point I am not particularly sure how you generate your changelogs or choose what is included.

from dry-initializer.

nepalez avatar nepalez commented on July 27, 2024

By mistake I've added the entry for 2.5.0 under 2.6.0, so now I've fixed it by just adding one line to then README.md. This is a good news.

The bad one is v2.6.0 broke rom, so it has been yanked by @solnic. I've rolled back master to v2.5.0 as well. I think, we need more investigation about your PR that add @default_null. For now I see no reason why it breaks the backward compatibility.

Let's start from scratch. Could you remind, please, why this distinction between @null and @default_null was needed?

from dry-initializer.

bjeanes avatar bjeanes commented on July 27, 2024

Hi @nepalez, I think you might be confusing me with the author of #46. I also made a change touching @null though, so this is understandable. My changes are in 2.5.0 which didn't break rom, as I understand it.

As a refresher, my change was #39, which just swapped the right and left hand of the comparison for null, because AR's #== had side effects 😱.

from dry-initializer.

bjeanes avatar bjeanes commented on July 27, 2024

Looking at latest CHANGELOG.md, I don't think it's right. Are you sure added the 2.5.0 changes as 2.6.0 originally? The latest 2.5.0 entry mentions the reverted commit 128b484 from #46.

from dry-initializer.

bjeanes avatar bjeanes commented on July 27, 2024

I added a comment on your latest commit with what I believe is probably the real contents of 2.5.0 changes: 42cfc4e#r31064892

from dry-initializer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.