Comments (6)
@bjeanes Hi! Thank you, you're right
Will restore it on weekend
from dry-initializer.
Hi @nepalez just a casual and hopefully friendly reminder about this one. I'd offer to help but at this point I am not particularly sure how you generate your changelogs or choose what is included.
from dry-initializer.
By mistake I've added the entry for 2.5.0
under 2.6.0
, so now I've fixed it by just adding one line to then README.md
. This is a good news.
The bad one is v2.6.0 broke rom
, so it has been yanked by @solnic. I've rolled back master to v2.5.0 as well. I think, we need more investigation about your PR that add @default_null
. For now I see no reason why it breaks the backward compatibility.
Let's start from scratch. Could you remind, please, why this distinction between @null
and @default_null
was needed?
from dry-initializer.
Hi @nepalez, I think you might be confusing me with the author of #46. I also made a change touching @null
though, so this is understandable. My changes are in 2.5.0 which didn't break rom
, as I understand it.
As a refresher, my change was #39, which just swapped the right and left hand of the comparison for null, because AR's #==
had side effects 😱.
from dry-initializer.
Looking at latest CHANGELOG.md
, I don't think it's right. Are you sure added the 2.5.0 changes as 2.6.0 originally? The latest 2.5.0 entry mentions the reverted commit 128b484 from #46.
from dry-initializer.
I added a comment on your latest commit with what I believe is probably the real contents of 2.5.0 changes: 42cfc4e#r31064892
from dry-initializer.
Related Issues (20)
- Overriding of dry-container dependencies creates unexpected behaviour HOT 1
- Work out semver-appropriate way to release now-yanked 2.6.0 changes [was: "2.6.0 broke public API"] HOT 1
- Tokenize hash params HOT 2
- dry-initializer relies on Symbol#to_proc#arity being -1 HOT 1
- Non-lazy defaults are harder to use with specs HOT 3
- [Feature Request] Option to skip type checking in certain cases HOT 3
- Getters provide inconsistent results in debugging HOT 6
- Does the check for unknown positional parameters work? HOT 4
- Option "as" feature not working HOT 2
- Deprecation warning with Ruby 2.7: Using the last argument as keyword parameters is deprecated HOT 4
- Update cops from Rubocop HOT 1
- Ruby 2.7 warning HOT 3
- Upgrading to ruby 3 causes the initializer to unproperly handle auto-injected args HOT 2
- Feature - method signatures HOT 2
- [Security] Workflow ci.yml is using vulnerable action actions/checkout
- Ruby 3 support HOT 1
- ordering of option declarations should not prohibit forward reference in default procs HOT 6
- Why is downcase applied on target parameter / option? HOT 3
- Default value only if not nil HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dry-initializer.