Reader option about dry-configurable HOT 8 CLOSED

Nesting shouldn't be supported as it makes no sense :)

from dry-configurable.

@AMHOL I think we can close this one

from dry-configurable.

What behavior for reader should be for this example?

class Foo 
  extend Dry::Configurable

  setting :database, reader: true do
    setting :dsn, 'sqlite:memory', reader: true
  end
end

from dry-configurable.

I'm not sure it would be necessary on nested settings as a reader on the root setting would make the child settings available as i.e. database.dsn

from dry-configurable.

Not sure about this as it introduces different behaviour based on the level of nesting, plus you could just use Forwardable and delegators to do the same

from dry-configurable.

@AMHOL wdym?

from dry-configurable.

@AMHOL's probably talking about what happens with something like this, for example?

setting :foo do
  setting :bar, reader: true
end

from dry-configurable.

@solnic I'm not sure the option should be supported though, the way the library works it can't be implemented on the root level without also being implemented at the nested level, and I'm not sure whether a library for configuration should support an option to expand the interface of an object. With Forwardable I meant something like:

class App
  extend Dry::Configurable

  class << self
    extend Forwardable
    def_delegator :config, :database
  end

  # Pass a block for nested configuration (works to any depth)
  setting :database do
    # Can pass a default value
    setting :dsn, 'sqlite:memory'
  end
  # Defaults to nil if no default value is given
  setting :adapter
end

App.database
=> #<struct dsn="sqlite:memory">

from dry-configurable.