Can't add setting when config has been accessed about dry-configurable HOT 11 CLOSED

Re-opening this as it's one of the caveats I want to address before 1.0.0. ie dry-system could benefit from this and possibly many more gems.

from dry-configurable.

One use case I have for this is a setting whose default value should be set to the value of a different setting:

  class A extend Dry::Configurable
    setting :foo, 5
    setting :bar, self.config.foo
  end

This causes a crash right now.

from dry-configurable.

Have you checked https://dry-rb.org/gems/dry-configurable/testing/ ?

from dry-configurable.

I hadn't, and the funny thing is that it was a PR of mine which introduced it :D

However, it doesn't change anything for this scenario:

class A
  extend Dry::Configurable

  setting :a
end

A.config
require 'dry/configurable/test_interface'
A.enable_test_interface
A.reset_config

class A
  setting :b
end

# => Dry::Configurable::AlreadyDefinedConfig (Cannot add setting +b+, A is already configured)

from dry-configurable.

Hm, we could fix it by resetting the @config_defined variable. Allowing adding settings dynamically though possible (as far as I can see) is 1) a breaking change 2) somewhat more involved, I wouldn't do it without a solid reason, it never was an issue beyond tests (again, AFAIK).

from dry-configurable.

somewhat more involved, I wouldn't do it without a solid reason

Yeah, I also felt uneasy with that. Finally, I have found a better way which doesn't need to reopen classes. So, at least for now, I'm going to close it.

Thank your for your help.

from dry-configurable.

@solnic a caveat you could encounter with this is that settings won't be added to subclasses when they haven been loaded before the new setting is added:

class A
  extend Dry::Configurable
end

class B < A
end

A.setting :a

A.settings # => #<Set: {:a}>
B.settings # => #<Set: {}>

class C < A
end

C.settings  # => #<Set: {:a}>

from dry-configurable.

I fixed it for real in #77

from dry-configurable.

oops, that's a different use case, re-opening 🙄

from dry-configurable.

This was fixed in 0.11.0

from dry-configurable.

@dorner your usecase works now too with 0.11.0

from dry-configurable.