including Dry::Configurable about dry-configurable HOT 6 CLOSED

I think we're gonna add this feature. We had a couple legit cases in dry-(system|web) land where having configurable objects would be useful.

from dry-configurable.

@AMHOL

But we can add an instance behaviour (PoC, fastest rough example):

module Dry
   module Configurable
      def self.included(base)
        # NOTE: ugly, but only for a PoC-example
        base.class_eval do
          def initialize
            @_config_mutex = ::Mutex.new
            @_settings = ::Concurrent::Array.new
            @_reader_attributes = ::Concurrent::Array.new
          end
        end
      end
    end
  end
end

and then:

class Config
  include Dry::Configurable
end

config = Config.new

config.setting :a, reader: true do
  setting :b, 'kek'
end

puts config.a.b # => "kek"

config.configure do |c|
  c.a.b = 'pek'
end

puts config.a.b # => "pek"

Sure, need to refactor a lot, but it really possible ;) WDYT?

from dry-configurable.

@ilnurnasyrov this library should only be used as a class-level DSL, AFAIK there is no documentation that says it should work when included, it could be updated to raise an exception when included, although I'm not sure it's worth doing that.

from dry-configurable.

@ilnurnasyrov you can simply define a proxy object with a dynamic module instantiation - and u will get a simple instance implementation without monkey patching :)

from dry-configurable.

@ergosploit do you have a use-case for instance-level configuration? It isn't supported intentionally because every time I've come across a use for it I've later realised that there was a better solution to the issues I had.

from dry-configurable.

Oh! thank you, i just needed to configure instances because i wanted to use two connections to third party api. I ended up using dry-initializer.

from dry-configurable.