Comments (15)
DrTimothyAldenDavis
commented on August 14, 2024
1
Timely catch since I'm close to posting v5.0.1. Thanks!
from graphblas.
DrTimothyAldenDavis
commented on August 14, 2024
I have it correct already, from the spec. BindOp1st binds the first
argument to a scalar, which is op(x,A). The matrix A is the 2nd argument
so it uses GrB_INP1. BindOp2nd binds the 2nd argument to a scalar, so it
uses GrB_INP0 to indicate if the matrix is to be transposed. See line 5034
of the v1.3 C API.
…On Tue, May 4, 2021 at 5:06 PM Erik Welch ***@***.***> wrote:
According to the spec (and what one would expect from the argument list to
the functions), GrB_Matrix_apply_BinaryOp1st uses GrB_INP1 to indicate
the input matrix is transposed, and GrB_Matrix_apply_BinaryOp2nd uses
GrB_INP0. SuiteSparse has these reversed both in code and in
documentation.
This looks easy enough to fix. Care if I take a stab at it?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#37>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYIIOKGXZIJE42MN3ACVL3TMBVYHANCNFSM44DQ5MBQ>
.
from graphblas.
eriknw
commented on August 14, 2024
What you describe is correct, but this is not what I currently see on master branch.
from graphblas.
DrTimothyAldenDavis
commented on August 14, 2024
Oh ... oops. I see it. I'm so dyslexic...
from graphblas.
eriknw
commented on August 14, 2024
For example GB_1st (bind-first) uses the GrB_INP0 descriptor value:
GraphBLAS/Source/GrB_Matrix_apply.c
Lines 89 to 90 in 92a7232
and GB_2nd (bind-second) uses GrB_INP1:
GraphBLAS/Source/GrB_Matrix_apply.c
Lines 139 to 140 in 92a7232
from graphblas.
DrTimothyAldenDavis
commented on August 14, 2024
Yup ... that's a bug -- thanks for catching it. It's a quick fix in the code but I also have to fix my MATLAB test suite which is harder.
from graphblas.
eriknw
commented on August 14, 2024
We're all a little lysdexic at times!
from graphblas.
eriknw
commented on August 14, 2024
Cool, I'll let you take care of it, since, yeah, I don't have access to MATLAB.
from graphblas.
DrTimothyAldenDavis
commented on August 14, 2024
It's the Test/test154.m that is backwards.
from graphblas.
DrTimothyAldenDavis
commented on August 14, 2024
Oh wait ... in the Test/test154.m I "simplify" things and just pass in both INP0 and INP1 as "tran" when I want to transpose the matrix, taking a shotgun approach. So the test would pass either way, which is broken.
from graphblas.
eriknw
commented on August 14, 2024
Ooh, looking forward to a version 5!
from graphblas.
eriknw
commented on August 14, 2024
In the meantime, your test suite suggests an easy fix for current user-code: just set both descriptors :)
from graphblas.
DrTimothyAldenDavis
commented on August 14, 2024
Right! That will work with either v4.0.3 which has this bug, and v5.0.1
which will be fixed.
Good catch. This is bug 23 I think. That is, the 23rd bug since v1.0.0 in
2017.
On Tue, May 4, 2021 at 5:54 PM Erik Welch ***@***.***> wrote:
In the meantime, your test suite suggests an easy fix for current
user-code: just set both descriptors :)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYIIOPXIIP2MUTN2L76YZDTMB3I3ANCNFSM44DQ5MBQ>
.
--
Sent from Gmail Mobile
from graphblas.
DrTimothyAldenDavis
commented on August 14, 2024
I just fixed this in the stable v5.0.2. Thanks for catching it.
from graphblas.
eriknw
commented on August 14, 2024
Hooray! I'm always surprised when I find a bug in SuiteSparse:GraphBLAS.
from graphblas.
Related Issues (20)
- Set name of UDT when serializing HOT 12
- Build broken with spaces in folder names HOT 8
- build fails on windows 11 using CMake with MinGW HOT 5
- ISEQ monoids HOT 7
- Fix bitwise operator monoid names HOT 4
- Remove va_arg HOT 5
- GrB_Vector_(de)serialize HOT 6
- Sparse Index Space HOT 2
- Removed symbols without soname bump HOT 12
- atomic*: Undefined symbol on armel and mipsel architectures HOT 33
- "ZEROB" Binary Operator HOT 3
- GxB sort with smaller (or larger) output objects
- cpu_features: Build error for MinGW HOT 13
- Size of Static Library HOT 16
- Link error with Intel igx and Ninja generator on Windows HOT 9
- Optimisation report causing build failure when using Intel oneAPI HOT 2
- nvals weirdness with 8.0.0 for max-sized Vector HOT 6
- Where is `GxB_Context_error`? HOT 3
- Why was `nthreads` and `chunks` remove from the descriptor? HOT 5
- dynamic connectivity in the language of graphblas HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphblas.