Git Product home page Git Product logo

Comments (4)

danielrh avatar danielrh commented on June 11, 2024 2

good points here. Pushed a new release that turns it off by default. End-projects can still use it if necessary.

from rust-brotli.

danielrh avatar danielrh commented on June 11, 2024

from rust-brotli.

nyurik avatar nyurik commented on June 11, 2024

If ffi is not needed for "typical" operations, then yes, I think we should not require it by default. The problem is that now there might be a lot of projects that simply used the default without realizing they did not needed it, and the downstream users end up with conflicts. The bigger issue is that removing ffi from the default feature is also a breaking change... Luckly v4 hasn't been out for long, so perhaps simply releasing v5 without it is a good way forward

from rust-brotli.

nyurik avatar nyurik commented on June 11, 2024

P.S. Note that in many cases the end user is not even aware of which brotli version is being used because they are not using it directly. For example, actix-http uses v3, and async-compression uses v4 - so if used together, they would fail

from rust-brotli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.