Comments (4)
good points here. Pushed a new release that turns it off by default. End-projects can still use it if necessary.
from rust-brotli.
from rust-brotli.
If ffi
is not needed for "typical" operations, then yes, I think we should not require it by default. The problem is that now there might be a lot of projects that simply used the default without realizing they did not needed it, and the downstream users end up with conflicts. The bigger issue is that removing ffi
from the default
feature is also a breaking change... Luckly v4 hasn't been out for long, so perhaps simply releasing v5 without it is a good way forward
from rust-brotli.
P.S. Note that in many cases the end user is not even aware of which brotli version is being used because they are not using it directly. For example, actix-http
uses v3, and async-compression
uses v4 - so if used together, they would fail
from rust-brotli.
Related Issues (20)
- into_inner on Decompressor discards data due to buffering
- Add a helper for compressing a slice into a vec
- Protection against zip bombs HOT 1
- https://github.com/dropbox/dropbox-sdk-java/blob/master/License.txt
- Ghh
- Code style HOT 1
- 3.3.4 cannot be built on stable release channel
- drop in replacement of brotli, how so? HOT 1
- Changing the default quality level HOT 1
- Does rust-brotli support self-contained compressed data?
- Multithreaded compression HOT 2
- Amir
- Support stream testing without expecting a decompressed stream
- Publish new version HOT 2
- BrotliEncoderCompressStream/BrotliDecompressStream should use &mut [mem::MaybeUninit<u8>] for output HOT 4
- Tags for 3.4.0 and 3.5.0 are missing HOT 1
- Merge decompressor into this repo
- Prevent exposing internal APIs as public HOT 1
- `BrotliDecompress` panics if output writer stops accepting data HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-brotli.