Git Product home page Git Product logo

Comments (8)

Sluggerman avatar Sluggerman commented on July 19, 2024 3

Hello Drone team,

Firstly thank you for the great tool and all your hard work!

We are also in need of being able to set kube2iam pod annotations, so jobs could natively authenticate in AWS with number of use cases such as ECR, S3, Vault AWS auth etc.

We would really appreciate if this could be added to Drone sooner.

from drone-runtime.

kevtaylor avatar kevtaylor commented on July 19, 2024 2

@srhopkins We have an opensource project that uses mutatingwebhooks to apply rules onto namespaces, which might be an option for you https://github.com/HotelsDotCom/kube-graffiti

from drone-runtime.

srhopkins avatar srhopkins commented on July 19, 2024

Is there a work around for this currently? We are blocked as we're unable to access s3 buckets that we use kiam roles with.

from drone-runtime.

willejs avatar willejs commented on July 19, 2024

@bradrydzewski there are two PRs that address this, can you review them?

from drone-runtime.

willejs avatar willejs commented on July 19, 2024

@kevtaylor thats a really cool project. I don't think this will work with the way drone k8s jobs currently work though? The jobs expose info via annotations instead of labels, and the only labels that it sets in the spec that you could use field selectors is job-name, which would be a bit nasty... What are you guys doing? I am curious.
I think the answer is to either fix the runtime annotations as per this PR or use kube-graffiti when there are proper labels added?

from drone-runtime.

kevtaylor avatar kevtaylor commented on July 19, 2024

@willejs kube-grafitti can do labels and annotations - we use it to decorate namespaces / kiam policies in general - but appreciate it may be tricky if annotations are dynamic

from drone-runtime.

willejs avatar willejs commented on July 19, 2024

@kevtaylor yeah, you can paint labels or annotations, but you can only match on labels or field selectors (name, namespace) so i don't think it's going to work well in the current state?
Adding the annotation to the job would work, but I am also thinking that this might not even be the way to go considering the other runtime changes...
#69

from drone-runtime.

bradrydzewski avatar bradrydzewski commented on July 19, 2024

there is a new (still experimental) kubernetes runner that supports annotations:
https://github.com/drone-runners/drone-runner-kube

kind: pipeline
type: kubernetes

metadata:
  annotations:
    foo: bar

steps: [ ... ]

from drone-runtime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.