Backstage 1.27 Build fails with Toolbox 1.21.0 about backstage-plugin-toolbox HOT 21 OPEN

I'm still getting the same error with backstage v1.28.0 and @drodil/[email protected]. Downgrading to 1.20.5 fixes it of course but I was expecting the 1.28.0 release to fix it. Is there something else I need to reset/update/clean or are others also still getting this build error?

from backstage-plugin-toolbox.

Can confirm that I have the error with Backstage 1.28.4

from backstage-plugin-toolbox.

I could not replicate this problem, upgraded to backstage version 1.27.5 and installed version 1.21.0 of this plugin. No Error message, no problem, works as expected.

my tsconfig

{
  "extends": "@backstage/cli/config/tsconfig.json",
  "include": [
    "packages/*/src",
    "plugins/*/src",
    "plugins/*/dev",
    "plugins/*/migrations"
  ],
  "exclude": [
    "node_modules"
  ],
  "compilerOptions": {
    "jsx": "react",
    "outDir": "dist-types",
    "rootDir": ".",
    "resolveJsonModule": true,
  }
}

Tried with ES2020 as target, still no problem

from backstage-plugin-toolbox.

Confirm I'm seeing it too. This change backstage/backstage#24776 should resolve it once released.

from backstage-plugin-toolbox.

You can't really do this, I've edited the code directly in my node_modules

from backstage-plugin-toolbox.

How about proposing upstream change? I think @Rugvip changed already some of these to 2020?

from backstage-plugin-toolbox.

@helltf any idea why this is happening? The latest release contained only the new tool for generating types.

from backstage-plugin-toolbox.

no clue, maybe the quicktype package is not compatible with es2019

from backstage-plugin-toolbox.

@fshowalter thanks for confirming, probably have to live with this until the next backstage release on 18th of June. So my suggestion is to go with 1.20.5 until that.

from backstage-plugin-toolbox.

Thanks for reporting, it's weird as the backstage/backstage#24776 should have fixed that. I will take a look if I have time before my holiday (starting tomorrow) and if nothing else, we have to get rid of the breaking tool to continue getting new ones in.

from backstage-plugin-toolbox.

Ah, probably if I bump also the toolbox to use the latest backstage packages it could fix the issue.

from backstage-plugin-toolbox.

Next try with v1.22.1!

from backstage-plugin-toolbox.

Nope, didn't help. I don't know if the tsconfig.json should be changed somehow or if we should just get rid of the breaking tool, WDYT?

from backstage-plugin-toolbox.

I don't think it's a Typescript issue per se, but an esbuild one, as I think Backstage uses that versus Typescript compiler for the source transformation these days.

The frustrating thing is, I haven't found a way to debug it to see which file/line is tripping the error and/or where it's getting the 2019 config....

from backstage-plugin-toolbox.

After some debugging found out that setting this to es2020 in the backstage cli package https://github.com/backstage/backstage/blob/d73302be50d5dcc91ff6fc6da60355183abeb8f3/packages/cli/src/lib/bundler/optimization.ts#L31 the build no longer fails.

The error originates from the quicktype-core package

from backstage-plugin-toolbox.

How do you set this to es2020 in the backstage cli? I got same issue with backstage "1.29.1" and toolbox 1.22.1.

I don't really see the option in doc to set it. The latest code is here https://github.com/backstage/backstage/blob/b24d5b0aa4fba4a26db16d0d695e140b5da1f233/packages/cli/src/lib/bundler/optimization.ts#L37

from backstage-plugin-toolbox.

backstage/backstage#25737 @drodil I've created this Issue for reference. Not sure if I have the time to propose a PR for this

from backstage-plugin-toolbox.

Made a PR to upstream, have to wait for the next release :(

from backstage-plugin-toolbox.