Request: Move handlers into their own functions about tidy-url HOT 8 OPEN

That sounds good to me as long as the config object is optional. My original goal was simplicity, being able to pass any URL to be cleaned with ease, but I don't mind being able to customize the clean for more advanced users. So far the main options were for AMP links and redirects, as you've probably seen already

from tidy-url.

Thank you

from tidy-url.

I'm not going to let you push code into the main branch that hasn't been tested, reviewed or even seen by me.

from tidy-url.

I am interested in taking this on. I'm thinking (as a first pass at least) of splitting each of the aforementioned things into functions. Also, what are your thoughts on clean() taking a config object or something so that the caller can decide which parts of the cleaning process they want to run? I'm thinking object to allow for more flexibility & ease in adding/removing options down the line.

from tidy-url.

I am interested. I will refactor the code and add some unit tests to make the method cleaner and more readable. Additionally, I will organize the handlers into different files.

from tidy-url.

I think i do not have permission to push
git push --set-upstream origin refactor/handlers
remote: Permission to DrKain/tidy-url.git denied to apodi.
fatal: unable to access 'https://github.com/DrKain/tidy-url.git/': The requested URL returned error: 403
could you please add me as Collaborator

from tidy-url.

Create a pull request. I'll review it when I get the time and if it's good I'll merge

from tidy-url.

PR is ready for review #108

from tidy-url.