Git Product home page Git Product logo

Comments (3)

kjeffery avatar kjeffery commented on September 26, 2024

There is currently no -version flag, but a couple of options exist.

When built, scene_rdl2 creates a version.h file that lists the scene_rdl2 in a few formats. The version of scene_rdl2 and MoonRay are not correlated (except that we often happen to change their version numbers simultaneously). Still, the scene_rdl2 version usually indicates which version of MoonRay is being used since we tend to release them in lockstep.

MoonRay does issue a version number in both the human-readable output (-info as a command-line flag or info in the scene variables) or in the CSV file (-stats <file> as a command-line flag or stats_file in the scene variables).

However, if I remember the implementation, MoonRay grabs its version from the installation path. I have yet to try this outside of the DreamWorks ecosystem.

Scene_rdl2's Version.h:

// Copyright 2022-2023 DreamWorks Animation LLC
// SPDX-License-Identifier: Apache-2.0

#pragma once
#define RDL2_VERSION_STRING "11.7.0.9999"

#define RDL2_VERSION_MAJOR 11
#define RDL2_VERSION_MINOR 7
#define RDL2_VERSION_PATCH 0
#define RDL2_VERSION_BUILD 9999

#define RDL2_VERSION_NUMBER 11000700009999

From MoonRay's human-readable logs:

00:00:00  470.1 MB | Moonray version                  = 13.7.0.9999

From MoonRay's CSV file:

Moonray version,13.7.0.9999

from openmoonray.

sfjohnston avatar sfjohnston commented on September 26, 2024

Thanks for the info!
Having "/installs/openmoonray/include/scene_rdl2/version.h" available is a good hint.

When I run with -info (log) I get:
00:00:00 430.4 MB | Moonray version = unknown
and when I run with -stats (csv) I similarly get:
Moonray version,unknown

Looking at the code for getMoonrayVersion() in RenderStatistics.cc, it appears that your in-house build system includes the version in the executable path, and you pull it out of the path rather than manage the logic internally.

The only way to see this is to start it up a render with an input file. Perhaps if "moonray -info" or "moonray -stats stats.csv" is run without an input, it could report system stuff prior to issuing "No scene file specified." Though it may be easier to add -version.)

This is a low priority.

The build system could use git status and git rev-parse --short HEAD to form a string like:
"9b629e0" or "9b629e0 with uncommitted local changes".

from openmoonray.

kjeffery avatar kjeffery commented on September 26, 2024

I am not surprised that the MoonRay version output does not exist. I would like to see that be more robust.

from openmoonray.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.