csysdig Crashes When `~/chisels` Directory Is Missing about sysdig HOT 11 OPEN

Hey @nazdridoy! Thank you for the issue! We already patched this problem and release a patch release )0.35.2) 😁 On the other hand supporting XDG directories is a good point and maybe we should do that.

from sysdig.

We already patched this problem and release a patch release )0.35.2)

great! i guess it'll be available in arch repo soon.

supporting XDG directories is a good point and maybe we should do that.

please do... many of us would really appriciate that.

from sysdig.

I just tested with 0.35.3 and the issue is not fixed.
The problem appeared somewhere between 0.32.0 and 0.35.0.

I am building Debian package that installs chisels to /usr/share/sysdig/chisels.
sysdig still looks for chisels in current directory.
ln -s /usr/share/sysdig/chisels fixes the issue.

If there are any new config options to specify location of the chisels/plugins please let us know.

readlink("/root", 0x7ffc013228a0, 1023) = -1 EINVAL (Invalid argument)
readlink("/root/.chisels", 0x7ffc013228a0, 1023) = -1 ENOENT (No such file or directory)
faccessat2(AT_FDCWD, "/root/.chisels/", F_OK, AT_EACCESS) = -1 ENOENT (No such file or directory)
newfstatat(AT_FDCWD, "/proc/1/root", {st_mode=S_IFDIR|0755, st_size=424, ...}, 0) = 0
openat(AT_FDCWD, "/usr/lib/ssl/openssl.cnf", O_RDONLY) = 3
newfstatat(3, "", {st_mode=S_IFREG|0644, st_size=12324, ...}, AT_EMPTY_PATH) = 0
newfstatat(AT_FDCWD, "/proc/1/root", {st_mode=S_IFDIR|0755, st_size=424, ...}, 0) = 0
newfstatat(AT_FDCWD, "/usr/share/sysdig/plugins/", 0x7ffc01322330, 0) = -1 ENOENT (No such file or directory)
newfstatat(AT_FDCWD, "/root/.terminfo", 0x6342d493d6e0, 0) = -1 ENOENT (No such file or directory)
newfstatat(AT_FDCWD, "/etc/terminfo", {st_mode=S_IFDIR|0755, st_size=12, ...}, 0) = 0
newfstatat(AT_FDCWD, "/lib/terminfo", 0x6342d493d770, 0) = -1 ENOENT (No such file or directory)
newfstatat(AT_FDCWD, "/usr/share/terminfo", {st_mode=S_IFDIR|0755, st_size=84, ...}, 0) = 0
access("/etc/terminfo/x/xterm-1003", R_OK) = -1 ENOENT (No such file or directory)
access("/usr/share/terminfo/x/xterm-1003", R_OK) = 0
openat(AT_FDCWD, "/usr/share/terminfo/x/xterm-1003", O_RDONLY) = 3
newfstatat(3, "", {st_mode=S_IFREG|0644, st_size=3946, ...}, AT_EMPTY_PATH) = 0
access("/etc/terminfo/x/xterm-1003", R_OK) = -1 ENOENT (No such file or directory)
access("/usr/share/terminfo/x/xterm-1003", R_OK) = 0
openat(AT_FDCWD, "/usr/share/terminfo/x/xterm-1003", O_RDONLY) = 3
newfstatat(3, "", {st_mode=S_IFREG|0644, st_size=3946, ...}, AT_EMPTY_PATH) = 0
filesystem error: directory iterator cannot open directory: No such file or directory [./chisels/]
+++ exited with 1 +++

from sysdig.

Hey @eugenesan! The current version of sysdig (at least the one compiled by the ci) seems to work correctly even if no chisel directory is present. How are you building the package? By the way, it's possible to specify a specific chisel directory using the environment variable SYSDIG_CHISEL_DIR.

from sysdig.

@eugenesan by any chance, are you referring to the variable that sets the chisel directory during the build? In that case you should modify the file here:

userspace/sysdig/config_sysdig.h.in
24:#define SYSDIG_CHISELS_DIR "${CMAKE_INSTALL_PREFIX}/share/sysdig/chisels"

from sysdig.

@therealbobo
Sorry for the delayed response.

The issue is not related to the configuration.
I've tracked the problem to falcosecurity call:

But still the path never ends up in the list or being tested/accessed and I am getting: filesystem error: directory iterator cannot open directory: No such file or directory [./chisels/]

Maybe it's a toolchain or 3rd part library bug? I am testing on Ubuntu 23.10.

from sysdig.

This sounds really strange! I'm on ubuntu 22.04 and I cannot get a repro. Do you mind sharing the cmake commands you are using? 🤔 @eugenesan

from sysdig.

This sounds really strange! I'm on ubuntu 22.04 and I cannot get a repro. Do you mind sharing the cmake commands you are using? 🤔 @eugenesan

Here are the build logs for Ubuntu 23.10 (same issue on 24.04) and corresponding package:

• sysdig: https://launchpadlibrarian.net/718335621/buildlog_ubuntu-mantic-amd64.sysdig_0.35.0+repack-1build3~eugenesan~mantic2_BUILDING.txt.gz
• falcosecurity: https://launchpad.net/~eugenesan/+archive/ubuntu/ppa/+build/27894895/+files/buildlog_ubuntu-mantic-amd64.falcosecurity-libs_0.14.3-1~eugenesan~mantic1_BUILDING.txt.gz
• https://launchpad.net/~eugenesan/+archive/ubuntu/ppa/+packages?field.name_filter=sysdig&field.status_filter=published&field.series_filter=mantic

On 22.04 it worked with slighly older versions. Here are the logs and corresponding package:

• sysdig: https://launchpad.net/~eugenesan/+archive/ubuntu/ppa/+build/26475443/+files/buildlog_ubuntu-jammy-amd64.sysdig_0.32.0-1~eugenesan~jammy1_BUILDING.txt.gz
• falcosecurity: https://launchpad.net/~eugenesan/+archive/ubuntu/ppa/+build/26475308/+files/buildlog_ubuntu-jammy-amd64.falcosecurity-libs_0.11.3+repack-1~eugenesan~jammy1_BUILDING.txt.gz
• https://launchpad.net/~eugenesan/+archive/ubuntu/ppa/+packages?field.name_filter=sysdig&field.status_filter=published&field.series_filter=jammy

from sysdig.