Job modifiers inherit icons in game, but are marked as missing by plugin about paradox-language-support HOT 6 CLOSED

from paradox-language-support.

So the logic to get the actual modifier icon path should be optimized.
And it seems like there are some other 'inherit icons' situations.

from paradox-language-support.

Plugin now simply get the modifier icon path by template expression "gfx/interface/icons/modifiers/$.dds"， where "$" is the modifier name.

It seems like there should be some addtional inference logic (and are there others?),
and the icon file could also be a png file.

from paradox-language-support.

Some others:

• Economic category modifiers use icons related to their resources (there's some nuance to this one, worth careful investigation, particularly for modifiers which don't point at a specific resource)
• Scripted modifiers can specify an icon in their definition.

All of these (note the warnings in the scroll bar) have icons in-game

Edit: Just noticed the priest unity additive modifier using an old Russian loc entry from one of our "orphaned" loc files in favour of the vanilla english loc. Unsure if that priority order is desirable or not. I've removed the entry from the file since it wasn't being used any more anyway.

from paradox-language-support.

from paradox-language-support.

Not sure what's the icon generation rule for template-based modifier (e.g. shipsize_<ship_size>_build_speed_mult).

from paradox-language-support.