Incompatibility between DragonflyDB and redis/rueidis client about dragonfly HOT 3 OPEN

Hi @thisismz, this should be a bug (we support both RESP3 and client side tracking).

Let me get back to you on this one

from dragonfly.

Hi @thisismz , I run your example with go 1.21.6. First, I am not quite sure how you are getting this output:

panic: Unknown subcommand or wrong number of arguments for 'TRACKING'. Try CLIENT HELP.: ClientOption.DisableCache must be true for redis not supporting client-side caching or not supporting RESP3 [recovered] panic: Unknown subcommand or wrong number of arguments for 'TRACKING'. Try CLIENT HELP.: ClientOption.DisableCache must be true for redis not supporting client-side caching or not supporting RESP3

When I run it, I just get: panic: syntax error.

How I reproduced: go mod init test && go get github.com/redis/rueidis && go run . . The good thing is at least I managed to reproduce and figure out what the issue is. We recently added support for the CLIENT TRACKING subcommand in #2139
However, it appears that we only added partial support. The only tthing we accept is CLIENT TRACKING ON/OFF. However, rueidis sends CLIENT TRACKING ON OPTIN and dragonfly fails to parse the OPTIN arguments and returns with a syntax error.

Therefore to resolve this we need to parse the OPTIN argument + test with ruedis.

@romange what's the priority of this? Also, I noticed that we need to update the docs https://www.dragonflydb.io/docs/command-reference/compatibility to include CLIENT TRACKING I am mentioning it here so we don't forget

from dragonfly.

Yes, it seems that you are correct; the error appears to be different between Linux and Windows. I executed this on my MacBook and received the same error as you. let me the opportunity to double-check.

However, it seems that by adding the following parameter, it appears that the issue has been resolved:

DisableCache: true

client, err := rueidis.NewClient(
	rueidis.ClientOption{
	InitAddress: []string{"127.0.0.1:6379"},
	DisableCache: true,
})

But when we set a key twice, we receive the following error:

panic: redis nil message
goroutine 1 [running]:
main.main()
        /Users/mozaffari/Documents/tst/dragonfly/main.go:22 +0x590

It seems like we might not have overwriting capabilities.

Hi @thisismz , I run your example with go 1.21.6. First, I am not quite sure how you are getting this output:

panic: Unknown subcommand or wrong number of arguments for 'TRACKING'. Try CLIENT HELP.: ClientOption.DisableCache must be true for redis not supporting client-side caching or not supporting RESP3 [recovered] panic: Unknown subcommand or wrong number of arguments for 'TRACKING'. Try CLIENT HELP.: ClientOption.DisableCache must be true for redis not supporting client-side caching or not supporting RESP3

When I run it, I just get: panic: syntax error.

How I reproduced: go mod init test && go get github.com/redis/rueidis && go run . . The good thing is at least I managed to reproduce and figure out what the issue is. We recently added support for the CLIENT TRACKING subcommand in #2139 However, it appears that we only added partial support. The only tthing we accept is CLIENT TRACKING ON/OFF. However, rueidis sends CLIENT TRACKING ON OPTIN and dragonfly fails to parse the OPTIN arguments and returns with a syntax error.

Therefore to resolve this we need to parse the OPTIN argument + test with ruedis.

@romange what's the priority of this? Also, I noticed that we need to update the docs https://www.dragonflydb.io/docs/command-reference/compatibility to include CLIENT TRACKING I am mentioning it here so we don't forget

from dragonfly.