Git Product home page Git Product logo

Comments (10)

benknoble avatar benknoble commented on August 15, 2024

I believe we've seen this before in various forms...

For example, it's mentioned in #37, which was supposedly closed by #62

However, I agree it still obscures comments. My one thought is that perhaps we shouldn't be reading comments when visually-selecting them? But still, anything we can do to make this a non-issue would be good.

@bricerebsamen do you have any suggestions on what might make a good replacement color for the DraculaSelection highlight color?

from vim.

bricerebsamen avatar bricerebsamen commented on August 15, 2024

we shouldn't be reading comments when visually-selecting them

sure but that's still a problem when editing the comments

from vim.

benknoble avatar benknoble commented on August 15, 2024

Agreed; that's why I'm asking for suggestions for a fix and recommending we fix it

from vim.

bricerebsamen avatar bricerebsamen commented on August 15, 2024

can you suggest a way for me to experiment? i.e. some vimrc line like let g:DraculaSelection = #rrggbb with the current color value. I can try to tweak and propose a new value.

from vim.

bricerebsamen avatar bricerebsamen commented on August 15, 2024

also maybe the proper tweak is to change the comment color to a slightly lighter value. same question: how would I experiment with that?

from vim.

benknoble avatar benknoble commented on August 15, 2024

DraculaSelection is defined here.

The selection value referenced above comes from here and is a list of

[ '#rrggbb' , closest_256-color_equivalent ]

Comment would be changed by experimenting with DraculaComment in that same file.

You'd most likely want to play around with a local copy of the repo and tweak the values in the colors file. You could edit it directly in your ~/.vim directory (idk your setup), or clone it fresh and start tweaking. Just make sure if you that you point your runtimepath over to the right copy so you can use that.

If you don't want to go to all that, you could probably try this in a vim session, but the above is more surefire.

:hi DraculaSelection [key]=[arg] " see :help :hi

from vim.

dsifford avatar dsifford commented on August 15, 2024

If I'm able to interject here 3 days later, I'd much rather see this discussed and changed here before doing anything drastic in this repo.

If there is agreement that this is a problem, the change should happen at the spec level, not at the implementation level.

At the end of the day, decisions like this should be left to @zenorocha

from vim.

zx1986 avatar zx1986 commented on August 15, 2024

I got the same problem too!
How did you fix this? @bricerebsamen

from vim.

bs avatar bs commented on August 15, 2024

Hitting this as well.

Screen Shot 2020-04-28 at 8 51 07 PM

from vim.

benknoble avatar benknoble commented on August 15, 2024

Closing this until we get resolution on dracula/dracula-theme#318

from vim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.