Git Product home page Git Product logo

Comments (2)

dpwe avatar dpwe commented on August 16, 2024 1

Fenglui -

Thanks for your comments.

1, In audfprint.py line 358, it should be
-v, --verbose Verbosity level

Although the use of verbosity is only as a boolean flag at present, the idea is to support different verbosity levels by accepting an argument. So I think this is WAI.

2, In audfprint_match.py line 183, it should be
results.resize((maxnresults, 7))

I think you're referring to the line that's

                        results.resize((maxnresults, results.shape[1]))

It's true that results.shape[1] is equal to 7, but the idea is to avoid having that "magic number" show up in too many places, in case I change the number of columns in the future. So although the existing code is inefficient, it's deliberate.

DAn.

from audfprint.

fengliu2014 avatar fengliu2014 commented on August 16, 2024

Thank you DAn,
You new commit on Apr 15th fixed the 2nd bug well.
It was results.resize((maxnresults, 5)) before.

from audfprint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.