Git Product home page Git Product logo

Comments (2)

dpa99c avatar dpa99c commented on July 21, 2024

This plugin (like all of mine) arose out of necessity when building a Cordova app which required the functionality. So the API could definitely be more elegant and it should be possible to automatically detect the bundle ID.

This would be a backwardly-incompatible change to the API, so as well as a major version bump, the release would need to be co-ordinated, for example with Ionic Native which provides a Typescript wrapper for this plugin.

Also couldn't we get rid of the separate inAppRating functions for iOS and instead use a unified rate function

Not sure about this, since the in-app rating dialog is not equivalent to launching the App Store page, since it only allows you to leave a rating, not a review.
Currently launch() has consistent cross-platform behaviour in that it allows you to launch the corresponding app store and leaving both a rating and review. The iOS-only rating() allows you to leave only a rating.
For my own apps, I prefer to encourage users to leave a review as well as a rating.

from cordova-launch-review.

dpa99c avatar dpa99c commented on July 21, 2024

Finally got around to this. v3 of the plugin should now automatically detect the app ID to use for the App Store URLs if not explicitly specified. Note the major version bump due to backwardly-incompatible API changes.

from cordova-launch-review.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.