Warn on generic type names in GetInterface about reflectionanalyzers HOT 6 CLOSED

I think we start with a warning notifying about a potential issue. We can always add a fix later.

from reflectionanalyzers.

Do you mean:

var type = typeof(string).GetInterface("System.Collections.Generic.IEnumerable`1");

If so it is similar to #28

from reflectionanalyzers.

Yes, but I want a warning even if the type is not known. So this should warn, too:

public static void Foo(Type type)
{
    type.GetInterface(typeof(IEnumerable<>));
}

from reflectionanalyzers.

Yes, reasonable but we can't write a fix, only warn. FirstOrDefault is a big assumption.

from reflectionanalyzers.

@JohanLarsson My thinking was that FirstOrDefault is highly visible and saves typing, but perhaps it should be SingleOrDefault anyway, replacing the ambiguous match exception with an invalid operation exception, and leaving further changes up to the user?

from reflectionanalyzers.

New analyzer or do we reuse REFL004 for this? Maybe best with a new.

from reflectionanalyzers.