Git Product home page Git Product logo

Comments (5)

KrzysztofCwalina avatar KrzysztofCwalina commented on May 20, 2024
  1. We need to have a set of tests that contributors can run to verify that their PRs have desired impact on perf, i.e. they would run the tests on master, then on the branch with changes, and compare the results.
  2. This project is not to do comparative benchmarking between different ML frameworks.

from machinelearning.

glebuk avatar glebuk commented on May 20, 2024

Sounds good, then we should probably rename the project/file to PerfRegressionTest.
Benchmarks are usually competitive.
Hopefully, in this case the benchmarks can be normalized against hardware, so that if the run is on a different hw platform it will not fail. Alternatively it should track the perf and the hw platform it runs against.

from machinelearning.

KrzysztofCwalina avatar KrzysztofCwalina commented on May 20, 2024

Hopefully, in this case the benchmarks can be normalized against hardware, so that if the run is on a different hw platform it will not fail. Alternatively it should track the perf and the hw platform it runs against.

The way we use such benchmarks is the following:

  1. Run the benchmark on master branch.
  2. Switch to PR branch
  3. Run the tests again.
  4. Post the diff in the PR description.

This "isolates" the hardware.
Having said that, the reports from BDN record information about the hardware, runtime, etc.

from machinelearning.

shauheen avatar shauheen commented on May 20, 2024

PR #62 merged this.

from machinelearning.

KrzysztofCwalina avatar KrzysztofCwalina commented on May 20, 2024

The PR just merged an infrastructure project and a "demo" test. I think it would be good to add more real tests, e.g. flight delay prediction. I would be more than happy to add it, if we think this is the right representative test and we add the data set to the repo.

from machinelearning.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.